From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] mmc: Test bus-width for old MMC devices (v2) Date: Thu, 16 Dec 2010 23:40:32 +0000 Message-ID: <20101216234032.GA17239@void.printf.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from void.printf.net ([89.145.121.20]:50791 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752897Ab0LPXkl (ORCPT ); Thu, 16 Dec 2010 18:40:41 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Takashi Iwai Cc: Philip Rakity , Aries Lee , zhangfei gao , wuqm@marvell.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Hi Takashi, On Wed, Dec 15, 2010 at 08:14:24AM +0100, Takashi Iwai wrote: > From: Aries Lee >=20 > Some old MMC devices fail with the 4/8 bits the driver tries to use > exclusively. This patch adds a test for the given bus setup and fall= s > back to the lower bit mode (until 1-bit mode) when the test fails. >=20 > [Major rework and refactoring by tiwai] > [Quirk addition and many fixes by prakity] >=20 > v1->v2: > - Rebased to the code with DDR support, set DDR bit properly > - Return always error when bus-switching fallback failed > - Define MMC_BUS_TEST_{R|W} in linux/mmc/mmc.h > - Add quirk MMC_CAP_BUS_WIDTH_TEST -- default not used for compatibi= lity > - Ignore errors on BUS_TEST_W -- improves chances test will work >=20 > Signed-off-by: Aries Lee > Signed-off-by: Takashi Iwai > Signed-off-by: Philip Rakity > Tested-by: Philip Rakity This looks good, but adds a warning: drivers/mmc/core/mmc.c: In function =E2=80=98mmc_init_card=E2=80=99: drivers/mmc/core/mmc.c:547: warning: =E2=80=98bus_width=E2=80=99 may be= used uninitialized in this function Thanks, --=20 Chris Ball One Laptop Per Child