From: Chris Ball <cjb@laptop.org>
To: Olof Johansson <olof@lixom.net>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 0/3 v2] Add SDHCI driver for Tegra
Date: Wed, 22 Dec 2010 08:06:29 +0000 [thread overview]
Message-ID: <20101222080629.GA19898@void.printf.net> (raw)
In-Reply-To: <1293004871-1918-1-git-send-email-olof@lixom.net>
Hi Olof,
On Wed, Dec 22, 2010 at 02:01:08AM -0600, Olof Johansson wrote:
> This is the second version of the SDHCI driver for tegra. I moved it
> over to a sdhci-pltfm variant, which turned out to be feasible -- at
> least as long as the platform_data is never required by sdhci-pltfm and
> can be used by the sub-driver.
>
> I also did away with wone of the quirks, since based on current testing
> it seems to no longer be required. If needed it can be reintroduced in
> some way or other later on instead.
At first glance, this looks *much* better as a -pltfm driver. Thanks
very much for redoing it!
> The one remaining quirk is of the kind that can be moved entirely into
> the driver, and I will look at doing so when I get around to cleaning
> up other quirks together with it.
Yes, that'd be great.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-12-22 8:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 8:01 [PATCH 0/3 v2] Add SDHCI driver for Tegra Olof Johansson
2010-12-22 8:01 ` [PATCH 1/3] sdhci: add quirk for max len ADMA descriptors Olof Johansson
2010-12-22 8:01 ` [PATCH 2/3] sdhci: don't finish commands in flight Olof Johansson
2010-12-22 8:08 ` Chris Ball
2010-12-22 9:38 ` Olof Johansson
2010-12-22 8:01 ` [PATCH 3/3] mmc: add sdhci-tegra driver for Tegra SoCs Olof Johansson
2010-12-22 16:22 ` Wolfram Sang
2010-12-22 19:22 ` Olof Johansson
2010-12-23 6:20 ` Mike Rapoport
2010-12-23 8:59 ` Olof Johansson
2010-12-22 8:06 ` Chris Ball [this message]
2010-12-22 16:05 ` [PATCH 0/3 v2] Add SDHCI driver for Tegra Wolfram Sang
2010-12-22 20:48 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222080629.GA19898@void.printf.net \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox