Re: [PATCH 1/2] mmc: agressive clocking framework v8

[Chris Ball <cjb@laptop.org>]

Hi Linus,

On Wed, Dec 22, 2010 at 09:50:12AM +0100, Linus Walleij wrote:
> Sure! Chris do you prefer this one instead?
> 
> From: Linus Walleij <linus.walleij@stericsson.com>
> Date: Wed, 22 Dec 2010 09:49:04 +0100
> Subject: [PATCH] mmc: check for > 1 clk_requests
> 
> Since we make sure the clock is enabled in the mmc_host_clk_exit()
> function we should expect a reference counter of 1, not 0.
> 
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
> ---
>  drivers/mmc/core/host.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 92e3370..b3ac6c5 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -235,7 +235,8 @@ static inline void mmc_host_clk_exit(struct mmc_host *host)
>  		mmc_host_clk_gate_delayed(host);
>  	if (host->clk_gated)
>  		mmc_host_clk_ungate(host);
> -	BUG_ON(host->clk_requests > 0);
> +	/* There should be only one user now */
> +	WARN_ON(host->clk_requests > 1);
>  }
> 
>  #else

Thanks, both of you, have merged this to mmc-next now.  We'll do some
rebasing to fold it in later.

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child