public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Olof Johansson <olof@lixom.net>
Cc: Chris Ball <cjb@laptop.org>,
	linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] sdhci: add quirk for max len ADMA descriptors
Date: Thu, 23 Dec 2010 12:26:06 +0100	[thread overview]
Message-ID: <20101223112606.GB5044@pengutronix.de> (raw)
In-Reply-To: <1293096475-19634-2-git-send-email-olof@lixom.net>

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Thu, Dec 23, 2010 at 03:27:54AM -0600, Olof Johansson wrote:
> Some controllers misparse segment length 0 as being 0, not 65536. Add
> a quirk to deal with it.
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>

I tend to NACK it (but I am not the maintainer). I'd prefer to see a
draft of your idea of a sdhci_add_host_fixup()-function :)

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2010-12-23 11:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-23  9:27 [PATCH 0/3 v3] Add SDHCI driver for Tegra Olof Johansson
2010-12-23  9:27 ` [PATCH 1/2] sdhci: add quirk for max len ADMA descriptors Olof Johansson
2010-12-23 11:26   ` Wolfram Sang [this message]
2010-12-23 18:26     ` Olof Johansson
2011-01-04 14:14       ` Wolfram Sang
2010-12-23  9:33 ` [PATCH 2/2] mmc: add sdhci-tegra driver for Tegra SoCs Olof Johansson
2010-12-23 11:23   ` Wolfram Sang
2010-12-23 18:27     ` Olof Johansson
2010-12-31  4:11       ` Chris Ball
2011-01-02  0:28     ` Olof Johansson
2011-01-04 14:24       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101223112606.GB5044@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox