From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] Fix sd/sdio/mmc initialization frequency retries Date: Tue, 4 Jan 2011 01:29:02 +0000 Message-ID: <20110104012901.GA8788@void.printf.net> References: <4D1A1B19.8000902@windriver.com> <20101231044942.GC19122@void.printf.net> <4D221748.5040701@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from void.printf.net ([89.145.121.20]:35440 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895Ab1ADB3I (ORCPT ); Mon, 3 Jan 2011 20:29:08 -0500 Content-Disposition: inline In-Reply-To: <4D221748.5040701@windriver.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Andy Ross Cc: linux-mmc@vger.kernel.org, Hein Tibosch , Pierre Ossman , Ben Nizette , Sascha Hauer , Adrian Hunter , Matt Fleming Hi Andy, On Mon, Jan 03, 2011 at 10:36:56AM -0800, Andy Ross wrote: > Subject: [PATCH] Fix sd/sdio/mmc initialization frequency retries > > Rewrite and clean up mmc_rescan() to properly retry frequencies lower > than 400kHz. Failures can happen both in sd_send_* calls and > mmc_attach_*. Break out "mmc_rescan_try_freq" from the frequency > selection loop. Symmetrize claim/release logic in mmc_attach_* API, > and move the sd_send_* calls there to make mmc_rescan easier to read. > > Signed-off-by: Andy Ross Thanks! Pushed to mmc-next for .38, after adding Reviewed-by: tags and removing the mmc_bus_{put,get}() comment, since I'll take care of that separately. -- Chris Ball One Laptop Per Child