Re: [PATCH 1/2 v2] mmc: tmio: handle missing HW interrupts

Chris Ball
2011-01-05T21:22:23Z

Hi Arnd,

On Wed, Dec 29, 2010 at 02:21:13PM +0100, Arnd Hannemann wrote:
> This patch addresses this problem by introducing timeouts for outstanding
> interrupts. If a hardware interrupt is missing, a soft reset will be performed
> to bring the hardware back to a working state.
> Tested with the SDHI hardware block in sh7372 / AP4EVB.
>
> Signed-off-by: Arnd Hannemann <arnd@arndnet.de>

This breaks compilation without CONFIG_TMIO_MMC_DMA=y, because it
attempts to compile tmio_mmc_reset_work() unconditionally even though
delayed_reset_work is only a member of tmio_mmc_host if TMIO_MMC_DMA=y:

drivers/mmc/host/tmio_mmc.c: In function ‘tmio_mmc_reset_work’:
drivers/mmc/host/tmio_mmc.c:357:31: error: ‘struct tmio_mmc_host’ has no member named ‘delayed_reset_work’

--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child