From: Chris Ball <cjb@laptop.org>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
linux-mmc@vger.kernel.org, trivial@kernel.org,
linux-kernel@vger.kernel.org, Axel Lin <axel.lin@gmail.com>,
David Vrabel <david.vrabel@csr.com>
Subject: Re: [PATCH] USB SD Host Controller: Including usb.h once is enough
Date: Mon, 10 Jan 2011 21:37:36 +0000 [thread overview]
Message-ID: <20110110213735.GA6509@void.printf.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1101102214500.32164@swampdragon.chaosbits.net>
Hi Jesper,
On Mon, Jan 10, 2011 at 10:19:11PM +0100, Jesper Juhl wrote:
> > On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
> > >
> > > Including usb.h once is enough in drivers/mmc/host/ushc.c
> > > This removes the duplicate.
> > >
> > >
> > > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Thanks, queued for .38.
> No reason.
> Didn't think of it as "newlines in the commit-msg", just as newlines
> providing a nice seperation between patch description and the patch
> itself. It never occurred to me that anyone would actually copy those
> blank lines into an actual commit message.
I don't copy anything into the commit message -- I like to run git-am
on the patch mail in my mailbox directly. In this case, git-am seems
to have removed the extra newlines itself, which was nice of it, but in
general please send mail such that from the start of the body of the
mail up to the "---" separator will become the commit message. Thanks!
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-01-10 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 20:56 [PATCH] USB SD Host Controller: Including usb.h once is enough Jesper Juhl
2011-01-10 21:05 ` Wolfram Sang
2011-01-10 21:19 ` Jesper Juhl
2011-01-10 21:37 ` Chris Ball [this message]
2011-01-10 21:39 ` Jiri Kosina
2011-01-10 21:37 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110213735.GA6509@void.printf.net \
--to=cjb@laptop.org \
--cc=axel.lin@gmail.com \
--cc=david.vrabel@csr.com \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox