* [PATCH] USB SD Host Controller: Including usb.h once is enough
@ 2011-01-10 20:56 Jesper Juhl
2011-01-10 21:05 ` Wolfram Sang
2011-01-10 21:37 ` Jiri Kosina
0 siblings, 2 replies; 6+ messages in thread
From: Jesper Juhl @ 2011-01-10 20:56 UTC (permalink / raw)
To: linux-mmc; +Cc: trivial, linux-kernel, Axel Lin, Chris Ball, David Vrabel
Including usb.h once is enough in drivers/mmc/host/ushc.c
This removes the duplicate.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
ushc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
index f8f65df..f08f944 100644
--- a/drivers/mmc/host/ushc.c
+++ b/drivers/mmc/host/ushc.c
@@ -19,7 +19,6 @@
#include <linux/module.h>
#include <linux/usb.h>
#include <linux/kernel.h>
-#include <linux/usb.h>
#include <linux/slab.h>
#include <linux/dma-mapping.h>
#include <linux/mmc/host.h>
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] USB SD Host Controller: Including usb.h once is enough
2011-01-10 20:56 [PATCH] USB SD Host Controller: Including usb.h once is enough Jesper Juhl
@ 2011-01-10 21:05 ` Wolfram Sang
2011-01-10 21:19 ` Jesper Juhl
2011-01-10 21:37 ` Jiri Kosina
1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2011-01-10 21:05 UTC (permalink / raw)
To: Jesper Juhl
Cc: linux-mmc, trivial, linux-kernel, Axel Lin, Chris Ball,
David Vrabel
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
>
> Including usb.h once is enough in drivers/mmc/host/ushc.c
> This removes the duplicate.
>
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Correct. Why the newlines in the commit-msg?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB SD Host Controller: Including usb.h once is enough
2011-01-10 21:05 ` Wolfram Sang
@ 2011-01-10 21:19 ` Jesper Juhl
2011-01-10 21:37 ` Chris Ball
0 siblings, 1 reply; 6+ messages in thread
From: Jesper Juhl @ 2011-01-10 21:19 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-mmc, trivial, linux-kernel, Axel Lin, Chris Ball,
David Vrabel
On Mon, 10 Jan 2011, Wolfram Sang wrote:
> On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
> >
> > Including usb.h once is enough in drivers/mmc/host/ushc.c
> > This removes the duplicate.
> >
> >
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
>
> Correct. Why the newlines in the commit-msg?
>
No reason.
Didn't think of it as "newlines in the commit-msg", just as newlines
providing a nice seperation between patch description and the patch
itself. It never occurred to me that anyone would actually copy those
blank lines into an actual commit message.
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB SD Host Controller: Including usb.h once is enough
2011-01-10 21:19 ` Jesper Juhl
@ 2011-01-10 21:37 ` Chris Ball
2011-01-10 21:39 ` Jiri Kosina
0 siblings, 1 reply; 6+ messages in thread
From: Chris Ball @ 2011-01-10 21:37 UTC (permalink / raw)
To: Jesper Juhl
Cc: Wolfram Sang, linux-mmc, trivial, linux-kernel, Axel Lin,
David Vrabel
Hi Jesper,
On Mon, Jan 10, 2011 at 10:19:11PM +0100, Jesper Juhl wrote:
> > On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
> > >
> > > Including usb.h once is enough in drivers/mmc/host/ushc.c
> > > This removes the duplicate.
> > >
> > >
> > > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Thanks, queued for .38.
> No reason.
> Didn't think of it as "newlines in the commit-msg", just as newlines
> providing a nice seperation between patch description and the patch
> itself. It never occurred to me that anyone would actually copy those
> blank lines into an actual commit message.
I don't copy anything into the commit message -- I like to run git-am
on the patch mail in my mailbox directly. In this case, git-am seems
to have removed the extra newlines itself, which was nice of it, but in
general please send mail such that from the start of the body of the
mail up to the "---" separator will become the commit message. Thanks!
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB SD Host Controller: Including usb.h once is enough
2011-01-10 21:37 ` Chris Ball
@ 2011-01-10 21:39 ` Jiri Kosina
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2011-01-10 21:39 UTC (permalink / raw)
To: Chris Ball
Cc: Jesper Juhl, Wolfram Sang, linux-mmc, linux-kernel, Axel Lin,
David Vrabel
On Mon, 10 Jan 2011, Chris Ball wrote:
> Hi Jesper,
>
> On Mon, Jan 10, 2011 at 10:19:11PM +0100, Jesper Juhl wrote:
> > > On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
> > > >
> > > > Including usb.h once is enough in drivers/mmc/host/ushc.c
> > > > This removes the duplicate.
> > > >
> > > >
> > > > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
>
> Thanks, queued for .38.
Perfect, dropped from my queue, thanks Chris.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB SD Host Controller: Including usb.h once is enough
2011-01-10 20:56 [PATCH] USB SD Host Controller: Including usb.h once is enough Jesper Juhl
2011-01-10 21:05 ` Wolfram Sang
@ 2011-01-10 21:37 ` Jiri Kosina
1 sibling, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2011-01-10 21:37 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-mmc, linux-kernel, Axel Lin, Chris Ball, David Vrabel
On Mon, 10 Jan 2011, Jesper Juhl wrote:
>
> Including usb.h once is enough in drivers/mmc/host/ushc.c
> This removes the duplicate.
>
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> ushc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
> index f8f65df..f08f944 100644
> --- a/drivers/mmc/host/ushc.c
> +++ b/drivers/mmc/host/ushc.c
> @@ -19,7 +19,6 @@
> #include <linux/module.h>
> #include <linux/usb.h>
> #include <linux/kernel.h>
> -#include <linux/usb.h>
> #include <linux/slab.h>
> #include <linux/dma-mapping.h>
> #include <linux/mmc/host.h>
Applied, thanks.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-10 21:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-10 20:56 [PATCH] USB SD Host Controller: Including usb.h once is enough Jesper Juhl
2011-01-10 21:05 ` Wolfram Sang
2011-01-10 21:19 ` Jesper Juhl
2011-01-10 21:37 ` Chris Ball
2011-01-10 21:39 ` Jiri Kosina
2011-01-10 21:37 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox