[REVIEW 2/2] ENGR0000137838 SDHCI Some eMMC cards can't work well in our BSP

[REVIEW 2/2] ENGR0000137838 SDHCI Some eMMC cards can't work well in our BSP

[Richard Zhu]

Pick up the patch from the community.

fc8a0985c2846292312556cba10b8a4182f55967
From: Hanumath Prasad <hanumath.prasad@stericsson.com>
Date: Tue, 10 Aug 2010 18:01:45 -0700
Subject: [REVIEW 2/2] mmc: only set blockaddressed for > 2GiB cards

A non-zero value of SEC_COUNT does not indicate that the card is sector
addressed. According to the MMC specification, cards
with a densitygreater than 2GiB are sector addressed.

Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Hanumath Prasad <hanumath.prasad@stericsson.com>
Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Signed-off-by: Richard Zhu <r65037@freescale.com>

 drivers/mmc/core/mmc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

ENGR0000137838 SDHCI Some eMMC cards can't work well in our BSP
sha             : ce733e353d0ac82c9a607b708f7de2b214408445
local branch is : imx_2.6.35
remote_branch   : origin/imx_2.6.35
branch_start    : v2.6.35.3

review-commits last updated 2010-12-31 13:49 /home/r65037/bin/linux-infra/tools/review-commits
d33ca02dca1624e86b1513e7bb7cce7281cd9590 don't generate pkg for linux-2.6-testbu
ild for cherry-pick experiment
git version 1.6.3.3


Running checkpatch.pl: 
total: 0 errors, 0 warnings, 10 lines checked

Your patch has no obvious style problems and is ready for submission.

checking header of ce733e3: ENGR0000137838 SDHCI Some eMMC cards can't work well in our BSP

check header: PASS

Checking kernel paths: PASS

review-commits: PASS
=============================================
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 4a9e2ed..95e13c2 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -222,7 +222,9 @@ static int mmc_read_ext_csd(struct mmc_card *card)
 			ext_csd[EXT_CSD_SEC_CNT + 1] << 8 |
 			ext_csd[EXT_CSD_SEC_CNT + 2] << 16 |
 			ext_csd[EXT_CSD_SEC_CNT + 3] << 24;
-		if (card->ext_csd.sectors)
+
+		/* Cards with density > 2GiB are sector addressed */
+		if (card->ext_csd.sectors > (2u * 1024 * 1024 * 1024) / 512)
 			mmc_card_set_blockaddr(card);
 	}
 
-- 
1.6.3.3

Re: [REVIEW 2/2] ENGR0000137838 SDHCI Some eMMC cards can't work well in our BSP

[Chris Ball]

Hi,

On Tue, Jan 11, 2011 at 10:02:48AM +0800, Richard Zhu wrote:
> Pick up the patch from the community.
> 
> fc8a0985c2846292312556cba10b8a4182f55967
> From: Hanumath Prasad <hanumath.prasad@stericsson.com>
> Date: Tue, 10 Aug 2010 18:01:45 -0700
> Subject: [REVIEW 2/2] mmc: only set blockaddressed for > 2GiB cards
> 
> A non-zero value of SEC_COUNT does not indicate that the card is sector
> addressed. According to the MMC specification, cards
> with a densitygreater than 2GiB are sector addressed.

What's the point of sending this mail to linux-mmc@?

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

RE: Re:[lnxrevli] [REVIEW 2/2] ENGR0000137838 SDHCI Some eMMC cards can't workwell in our BSP

[Zhu Richard-R65037]

Hi Chris:
I keep all the info of the original patch into my local patch.
The script the pull-tool used by us send out the emails to all the sign-off email address,
When I used this tool to push the local patch into our mainline.
Sorry to bring any inconvenience to you.

Best Regards
Richard Zhu

Best Regards
Richard Zhu


> -----Original Message-----
> From: Chris Ball [mailto:cjb@laptop.org]
> Sent: Tuesday, January 11, 2011 10:08 AM
> To: Zhu Richard-R65037
> Cc: Zhang Lily-R58066; root@udp161639uds.ap.freescale.net; ReviewList
> Linux-LNXREVLI; linux-mmc@vger.kernel.org
> Subject: Re:[lnxrevli] [REVIEW 2/2] ENGR0000137838 SDHCI Some eMMC cards
> can't workwell in our BSP
>
> Hi,
>
> On Tue, Jan 11, 2011 at 10:02:48AM +0800, Richard Zhu wrote:
> > Pick up the patch from the community.
> >
> > fc8a0985c2846292312556cba10b8a4182f55967
> > From: Hanumath Prasad <hanumath.prasad@stericsson.com>
> > Date: Tue, 10 Aug 2010 18:01:45 -0700
> > Subject: [REVIEW 2/2] mmc: only set blockaddressed for > 2GiB cards
> >
> > A non-zero value of SEC_COUNT does not indicate that the card is
> > sector addressed. According to the MMC specification, cards with a
> > densitygreater than 2GiB are sector addressed.
>
> What's the point of sending this mail to linux-mmc@?
>
> --
> Chris Ball   <cjb@laptop.org>   <http://printf.net/>
> One Laptop Per Child

Re: Re:[lnxrevli] [REVIEW 2/2] ENGR0000137838 SDHCI Some eMMC cards can't workwell in our BSP

[Chris Ball]

Hi Richard,

On Tue, Jan 11, 2011 at 02:17:08AM +0000, Zhu Richard-R65037 wrote:
> Hi Chris:
> I keep all the info of the original patch into my local patch.
> The script the pull-tool used by us send out the emails to all the sign-off email address,
> When I used this tool to push the local patch into our mainline.
> Sorry to bring any inconvenience to you.

Please modify the script so that it does not send mail to the people
in the Signed-off chain, or at least so that it never sends mail to
linux-mmc@.  The fact that you're importing a patch locally is off-topic
for the list.

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child