From: Chris Ball <cjb@laptop.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-mmc@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH] mmc: bfin_sdh: fix alloc size for private data
Date: Wed, 12 Jan 2011 04:05:34 +0000 [thread overview]
Message-ID: <20110112040532.GA28429@void.printf.net> (raw)
In-Reply-To: <1294803575-24087-1-git-send-email-vapier@gentoo.org>
Hi Mike, Sonic,
On Tue, Jan 11, 2011 at 10:39:35PM -0500, Mike Frysinger wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> The bfin_sdh driver allocates the wrong size for the private data
> in the mmc_host. The first parameter of mmc_alloc_host should be
> the size of the local driver struct rather than the common mmc_host.
>
> - mmc = mmc_alloc_host(sizeof(*mmc), &pdev->dev);
> + mmc = mmc_alloc_host(sizeof(*host), &pdev->dev);
Thanks, I'll add a stable tag and merge as a .38 fix. Mind if we
use "mmc_alloc_host(sizeof(struct sdh_host), &pdev-dev);" instead?
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-01-12 4:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 3:39 [PATCH] mmc: bfin_sdh: fix alloc size for private data Mike Frysinger
2011-01-12 4:05 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112040532.GA28429@void.printf.net \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sonic.zhang@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox