[PATCH] mmc: bfin_sdh: fix alloc size for private data

[PATCH] mmc: bfin_sdh: fix alloc size for private data

[Mike Frysinger]

From: Sonic Zhang <sonic.zhang@analog.com>

The bfin_sdh driver allocates the wrong size for the private data
in the mmc_host.  The first parameter of mmc_alloc_host should be
the size of the local driver struct rather than the common mmc_host.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 drivers/mmc/host/bfin_sdh.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c
index bac7d62..9193e06 100644
--- a/drivers/mmc/host/bfin_sdh.c
+++ b/drivers/mmc/host/bfin_sdh.c
@@ -462,7 +462,7 @@ static int __devinit sdh_probe(struct platform_device *pdev)
 		goto out;
 	}
 
-	mmc = mmc_alloc_host(sizeof(*mmc), &pdev->dev);
+	mmc = mmc_alloc_host(sizeof(*host), &pdev->dev);
 	if (!mmc) {
 		ret = -ENOMEM;
 		goto out;
-- 
1.7.4.rc1

Re: [PATCH] mmc: bfin_sdh: fix alloc size for private data

[Chris Ball]

Hi Mike, Sonic,

On Tue, Jan 11, 2011 at 10:39:35PM -0500, Mike Frysinger wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
> 
> The bfin_sdh driver allocates the wrong size for the private data
> in the mmc_host.  The first parameter of mmc_alloc_host should be
> the size of the local driver struct rather than the common mmc_host.
>  
> -	mmc = mmc_alloc_host(sizeof(*mmc), &pdev->dev);
> +	mmc = mmc_alloc_host(sizeof(*host), &pdev->dev);

Thanks, I'll add a stable tag and merge as a .38 fix.  Mind if we
use "mmc_alloc_host(sizeof(struct sdh_host), &pdev-dev);" instead?

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child