linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mmc: sdhci-of does not build on x86
@ 2011-01-14 12:29 Michal Marek
  2011-01-14 14:39 ` Chris Ball
  0 siblings, 1 reply; 2+ messages in thread
From: Michal Marek @ 2011-01-14 12:29 UTC (permalink / raw)
  To: Chris Ball; +Cc: linux-mmc, linux-kernel

After commit c10d1e2, CONFIG_OLPC selects CONFIG_OF, which enables to
select CONFIG_MMC_SDHCI_OF, which does not build on x86:

drivers/mmc/host/sdhci-of-core.c:24:25: fatal error: asm/machdep.h: No
such file or directory

Signed-off-by: Michal Marek <mmarek@suse.cz>
---

I don't know if the driver could possibly work on some OLPC hardware,
but it wasn't used on x86 before, so this patch won't make things any worse.

Michal
---
 drivers/mmc/host/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index afe8c6f..9901656 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -83,7 +83,7 @@ config MMC_RICOH_MMC
 
 config MMC_SDHCI_OF
 	tristate "SDHCI support on OpenFirmware platforms"
-	depends on MMC_SDHCI && OF
+	depends on MMC_SDHCI && OF && !X86
 	help
 	  This selects the OF support for Secure Digital Host Controller
 	  Interfaces.
-- 
1.7.3.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mmc: sdhci-of does not build on x86
  2011-01-14 12:29 [PATCH] mmc: sdhci-of does not build on x86 Michal Marek
@ 2011-01-14 14:39 ` Chris Ball
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Ball @ 2011-01-14 14:39 UTC (permalink / raw)
  To: Michal Marek; +Cc: linux-mmc, linux-kernel

Hi Michal,

On Fri, Jan 14, 2011 at 01:29:51PM +0100, Michal Marek wrote:
> After commit c10d1e2, CONFIG_OLPC selects CONFIG_OF, which enables to
> select CONFIG_MMC_SDHCI_OF, which does not build on x86:
> 
> drivers/mmc/host/sdhci-of-core.c:24:25: fatal error: asm/machdep.h: No
> such file or directory
> 
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
> 
> I don't know if the driver could possibly work on some OLPC hardware,
> but it wasn't used on x86 before, so this patch won't make things any worse.

Thanks very much for the patch, but Grant Likely already has a different
one queued that he's going to push to Linus, so we'll use that.

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-01-14 14:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-14 12:29 [PATCH] mmc: sdhci-of does not build on x86 Michal Marek
2011-01-14 14:39 ` Chris Ball

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).