From: Chris Ball <cjb@laptop.org>
To: "Dong, Chuanxiao" <chuanxiao.dong@intel.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature
Date: Thu, 20 Jan 2011 06:21:03 +0000 [thread overview]
Message-ID: <20110120062103.GB5732@void.printf.net> (raw)
In-Reply-To: <5D8008F58939784290FAB48F54975198352A15BFC0@shsmsx502.ccr.corp.intel.com>
Hi Chuanxiao,
On Thu, Jan 20, 2011 at 02:08:04PM +0800, Dong, Chuanxiao wrote:
> > I think these should probably be printed in decimal instead of hex.
(Will assume you agree with this, let me know if not.)
> > Hm, this way the sysfs files will show up regardless of whether we have
> > an eMMC device or an SD card, which is very confusing. Can you not check
> > whether enhanced_area_en == 1 before create these files?
> >
> SD card will not use this code when initializing. So I think these files only are created for eMMC card. If the eMMC card doesn't support enhanced area, can we use the same way like below scenario, exporting some value like -EINVAL to user? What do you think?
Oh, makes sense -- I agree, let's just use -EINVAL, and update the sysfs
ABI doc to mention that. Thanks!
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-01-20 6:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 12:57 [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature Chuanxiao Dong
2011-01-20 3:25 ` Chris Ball
2011-01-20 6:08 ` Dong, Chuanxiao
2011-01-20 6:21 ` Chris Ball [this message]
2011-01-20 6:55 ` Dong, Chuanxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120062103.GB5732@void.printf.net \
--to=cjb@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=chuanxiao.dong@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox