From: Chris Ball <cjb@laptop.org>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
David Vrabel <david.vrabel@csr.com>,
Axel Lin <axel.lin@gmail.com>,
trivial@kernel.org
Subject: Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c
Date: Mon, 24 Jan 2011 21:02:02 +0000 [thread overview]
Message-ID: <20110124210202.GA11110@void.printf.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1101242156050.10252@swampdragon.chaosbits.net>
Jesper,
On Mon, Jan 24, 2011 at 09:59:25PM +0100, Jesper Juhl wrote:
> We include linux/usb.h twice in drivers/mmc/host/ushc.c - once is enough.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> ushc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
> index f8f65df..f08f944 100644
> --- a/drivers/mmc/host/ushc.c
> +++ b/drivers/mmc/host/ushc.c
> @@ -19,7 +19,6 @@
> #include <linux/module.h>
> #include <linux/usb.h>
> #include <linux/kernel.h>
> -#include <linux/usb.h>
> #include <linux/slab.h>
> #include <linux/dma-mapping.h>
> #include <linux/mmc/host.h>
>
I've already replied to you ACKing this patch, and pushed it to mmc-next.
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-01-24 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 20:59 [PATCH] MMC, USHC: Don't double include usb.h in ushc.c Jesper Juhl
2011-01-24 21:02 ` Chris Ball [this message]
2011-01-24 21:05 ` Jesper Juhl
2011-01-24 21:06 ` Chris Ball
2011-01-24 21:14 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124210202.GA11110@void.printf.net \
--to=cjb@laptop.org \
--cc=axel.lin@gmail.com \
--cc=david.vrabel@csr.com \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox