[PATCH] MMC, USHC: Don't double include usb.h in ushc.c

[PATCH] MMC, USHC: Don't double include usb.h in ushc.c

[Jesper Juhl]

We include linux/usb.h twice in drivers/mmc/host/ushc.c - once is enough.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 ushc.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
index f8f65df..f08f944 100644
--- a/drivers/mmc/host/ushc.c
+++ b/drivers/mmc/host/ushc.c
@@ -19,7 +19,6 @@
 #include <linux/module.h>
 #include <linux/usb.h>
 #include <linux/kernel.h>
-#include <linux/usb.h>
 #include <linux/slab.h>
 #include <linux/dma-mapping.h>
 #include <linux/mmc/host.h>


-- 
Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c

[Chris Ball]

Jesper,

On Mon, Jan 24, 2011 at 09:59:25PM +0100, Jesper Juhl wrote:
> We include linux/usb.h twice in drivers/mmc/host/ushc.c - once is enough.
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
>  ushc.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
> index f8f65df..f08f944 100644
> --- a/drivers/mmc/host/ushc.c
> +++ b/drivers/mmc/host/ushc.c
> @@ -19,7 +19,6 @@
>  #include <linux/module.h>
>  #include <linux/usb.h>
>  #include <linux/kernel.h>
> -#include <linux/usb.h>
>  #include <linux/slab.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/mmc/host.h>
> 

I've already replied to you ACKing this patch, and pushed it to mmc-next. 

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c

[Jesper Juhl]

On Mon, 24 Jan 2011, Chris Ball wrote:

> Jesper,
> 
> On Mon, Jan 24, 2011 at 09:59:25PM +0100, Jesper Juhl wrote:
> > We include linux/usb.h twice in drivers/mmc/host/ushc.c - once is enough.
> > 
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> > ---
> >  ushc.c |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
> > index f8f65df..f08f944 100644
> > --- a/drivers/mmc/host/ushc.c
> > +++ b/drivers/mmc/host/ushc.c
> > @@ -19,7 +19,6 @@
> >  #include <linux/module.h>
> >  #include <linux/usb.h>
> >  #include <linux/kernel.h>
> > -#include <linux/usb.h>
> >  #include <linux/slab.h>
> >  #include <linux/dma-mapping.h>
> >  #include <linux/mmc/host.h>
> > 
> 
> I've already replied to you ACKing this patch, and pushed it to mmc-next. 
> 
Odd, I don't see that in my mailbox :-( But then I've had a few incidents 
of being bling in that regard lately, so it's probably my fault. Sorry.


-- 
Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c

[Chris Ball]

Hi,

On Mon, Jan 24, 2011 at 10:05:05PM +0100, Jesper Juhl wrote:
> > I've already replied to you ACKing this patch, and pushed it to mmc-next. 
> > 
> Odd, I don't see that in my mailbox :-( But then I've had a few incidents 
> of being bling in that regard lately, so it's probably my fault. Sorry.

It's okay.  Here's an archive of the thread:
  https://patchwork.kernel.org/patch/469621/

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

Re: [PATCH] MMC, USHC: Don't double include usb.h in ushc.c

[Jesper Juhl]

On Mon, 24 Jan 2011, Chris Ball wrote:

> Hi,
> 
> On Mon, Jan 24, 2011 at 10:05:05PM +0100, Jesper Juhl wrote:
> > > I've already replied to you ACKing this patch, and pushed it to mmc-next. 
> > > 
> > Odd, I don't see that in my mailbox :-( But then I've had a few incidents 
> > of being bling in that regard lately, so it's probably my fault. Sorry.
> 
> It's okay.  Here's an archive of the thread:
>   https://patchwork.kernel.org/patch/469621/
> 
Argh, reading it again I clearly remember that mail exchange. Must have 
deleted it from my mailbox by accident. 

-- 
Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.