public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: "Marc-André Hébert" <hebert.marcandre@gmail.com>
Cc: linux-mmc@vger.kernel.org
Subject: Re: Question about read only flag
Date: Mon, 31 Jan 2011 15:54:22 +0000	[thread overview]
Message-ID: <20110131155422.GA28016@void.printf.net> (raw)
In-Reply-To: <AANLkTi=odLjJtR19fMAyDNB9f+FV_Y-e48Li7fkZTKrv@mail.gmail.com>

Hi Marc-André,

On Mon, Jan 31, 2011 at 09:01:02AM -0500, Marc-André Hébert wrote:
> Hello,
> 
> I have on an OMAPL138 board running 2.6.33-rc4 (I would liked to try a
> more recent kernel but I do not have any boards which supports a more
> recent version). I noticed that I was unable to detect from sysfs if
> the inserted card was set to read only. The block device's
> /sys/class/block/mmcblk0/ro entry always reported 0. The read only
> gpio is correctly setup as opening the device for writing fails as
> expected.

Interesting, thanks -- no, I don't imagine this is intentional, and I can
confirm the behavior on an x86 laptop/SDHCI running 2.6.38-rc2.  Your
patch looks correct to me.  I'm surprised no-one's noticed this before.

Could you re-send it as a Git patch with a Signed-off-by: line, please?

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

      reply	other threads:[~2011-01-31 15:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 14:01 Question about read only flag Marc-André Hébert
2011-01-31 15:54 ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110131155422.GA28016@void.printf.net \
    --to=cjb@laptop.org \
    --cc=hebert.marcandre@gmail.com \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox