[PATCH] MMC: Fix the block device read only flag

[PATCH] MMC: Fix the block device read only flag

[Marc-André Hébert]

While the MMC handled the card's read only flag correctly on open,
it did not setup the flag in the allocated disk structure. The
consequence being that probing the /sys/class/block/mmcblkX/ro
attribute always reported 0.

Signed-off-by: Marc-Andre Hebert <hebert.marcandre@gmail.com>
---
 drivers/mmc/card/block.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index bfc8a8a..61d233a 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -621,6 +621,7 @@ static struct mmc_blk_data *mmc_blk_alloc(struct
mmc_card *card)
 	md->disk->private_data = md;
 	md->disk->queue = md->queue.queue;
 	md->disk->driverfs_dev = &card->dev;
+	set_disk_ro(md->disk, md->read_only);

 	/*
 	 * As discussed on lkml, GENHD_FL_REMOVABLE should:
-- 
1.6.0.4

Re: [PATCH] MMC: Fix the block device read only flag

[Chris Ball]

Hi,

On Mon, Jan 31, 2011 at 11:42:17AM -0500, Marc-André Hébert wrote:
> While the MMC handled the card's read only flag correctly on open,
> it did not setup the flag in the allocated disk structure. The
> consequence being that probing the /sys/class/block/mmcblkX/ro
> attribute always reported 0.
> 
> Signed-off-by: Marc-Andre Hebert <hebert.marcandre@gmail.com>
> ---
>  drivers/mmc/card/block.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index bfc8a8a..61d233a 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -621,6 +621,7 @@ static struct mmc_blk_data *mmc_blk_alloc(struct
> mmc_card *card)
>  	md->disk->private_data = md;
>  	md->disk->queue = md->queue.queue;
>  	md->disk->driverfs_dev = &card->dev;
> +	set_disk_ro(md->disk, md->read_only);
> 
>  	/*
>  	 * As discussed on lkml, GENHD_FL_REMOVABLE should:

Thanks very much, pushed to mmc-next and queued as a .38 fix.

(The patch was corrupt due to line-wrapping; something to fix for next
time.)
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child