[PATCH] mmc_test: Don't warn about not waiting for busy if controller can't do this

[PATCH] mmc_test: Don't warn about not waiting for busy if controller can't do this

[Pawel Moll]

If the MMC host controller does not support waiting for card signaling
busy state (MMC_CAP_WAIT_WHILE_BUSY cap), there is no point in prining
the relevant warning message.

Signed-off-by: Pawel Moll <pawel.moll@arm.com>
---
 drivers/mmc/card/mmc_test.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c
index 21adc27..0131c6c 100644
--- a/drivers/mmc/card/mmc_test.c
+++ b/drivers/mmc/card/mmc_test.c
@@ -226,9 +226,10 @@ static int mmc_test_wait_busy(struct mmc_test_card *test)
 
 		if (!busy && mmc_test_busy(&cmd)) {
 			busy = 1;
-			printk(KERN_INFO "%s: Warning: Host did not "
-				"wait for busy state to end.\n",
-				mmc_hostname(test->card->host));
+			if (test->card->host->caps & MMC_CAP_WAIT_WHILE_BUSY)
+				printk(KERN_INFO "%s: Warning: Host did not "
+					"wait for busy state to end.\n",
+					mmc_hostname(test->card->host));
 		}
 	} while (mmc_test_busy(&cmd));
 
-- 
1.6.3.3

Re: [PATCH] mmc_test: Don't warn about not waiting for busy if controller can't do this

[Matt Fleming]

On Mon, 17 Jan 2011 17:00:31 +0000
Pawel Moll <pawel.moll@arm.com> wrote:

> If the MMC host controller does not support waiting for card signaling
> busy state (MMC_CAP_WAIT_WHILE_BUSY cap), there is no point in prining
> the relevant warning message.
> 
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>
> ---
>  drivers/mmc/card/mmc_test.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)

Seems straight forward.

Reviewed-by: Matt Fleming <matt@console-pimps.org>

Re: [PATCH] mmc_test: Don't warn about not waiting for busy if controller can't do this

[Chris Ball]

Hi,

On Sun, Feb 06, 2011 at 07:53:59PM +0000, Matt Fleming wrote:
> On Mon, 17 Jan 2011 17:00:31 +0000
> Pawel Moll <pawel.moll@arm.com> wrote:
> 
> > If the MMC host controller does not support waiting for card signaling
> > busy state (MMC_CAP_WAIT_WHILE_BUSY cap), there is no point in prining
> > the relevant warning message.
> > 
> > Signed-off-by: Pawel Moll <pawel.moll@arm.com>
> > ---
> >  drivers/mmc/card/mmc_test.c |    7 ++++---
> >  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> Seems straight forward.
> 
> Reviewed-by: Matt Fleming <matt@console-pimps.org>

Thanks very much, pushed to mmc-next with Matt's Reviewed-by.

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child