From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH 1/2] dw_mmc: Run card detect tasklet during slot initialisation. Date: Thu, 10 Feb 2011 19:43:54 +0000 Message-ID: <20110210194353.GA19076@void.printf.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from void.printf.net ([89.145.121.20]:60618 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914Ab1BJTnz (ORCPT ); Thu, 10 Feb 2011 14:43:55 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Will Newton Cc: linux-mmc@vger.kernel.org, Matt Fleming Hi Will, On Thu, Feb 10, 2011 at 10:40:42AM +0000, Will Newton wrote: > We need to run the card detect tasklet at the end of slot initialisation > as it is possible that a card has been inserted prior to boot, so we don't > see an insertion interrupt and now the card is sitting there inserted but with > no power to it. > > Signed-off-by: Neil Jones > Signed-off-by: Will Newton > Reviewed-by: Matt Fleming > --- > drivers/mmc/host/dw_mmc.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 2fcc825..0b0bedd 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1441,6 +1441,13 @@ static int __init dw_mci_init_slot(struct > dw_mci *host, unsigned int id) > /* Card initially undetected */ > slot->last_detect_state = 0; > > + > + /* > + * Card may have been plugged in prior to boot so we > + * need to run the detect tasklet > + */ > + tasklet_schedule(&host->card_tasklet); > + > return 0; > } > Pushed to mmc-next, after: * rewrapping the commit message to be < 80 chars * removing the redundant first added newline in the patch * fixing the patch being corrupt due to line-wrapping Please fix these in the future (especially the linewrap), thanks, -- Chris Ball One Laptop Per Child