From: Arnd Bergmann <arnd@arndb.de>
To: Philip Rakity <prakity@marvell.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Mark Brown <markb@marvell.com>, Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 5/5] arm: mach-mmp: brownstone.c support multiple sd slots
Date: Mon, 14 Feb 2011 15:10:47 +0100 [thread overview]
Message-ID: <201102141510.48137.arnd@arndb.de> (raw)
In-Reply-To: <23C25DE3-86A5-4115-8539-D9837268F63F@marvell.com>
On Monday 14 February 2011, Philip Rakity wrote:
> +
> + gpio_direction_output(poweron, 1);
> + mdelay (20);
> + gpio_direction_output(reset, 0);
> + mdelay (20);
> + gpio_direction_output(reset, 1);
> + gpio_free(reset);
> + gpio_free(poweron);
mdelay is not nice, especially in boot code, because a lot of people
are interested in reducing boot times, and 40 miliseconds is definitely
in the range that people notice.
At the very least, change it from mdelay() to msleep(), to allow other
processes to continue.
Ideally, you can run the function in the background using schedule_work(),
but there may be better ways to do that for the entire platform code.
Arnd
prev parent reply other threads:[~2011-02-14 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 6:53 [PATCH 5/5] arm: mach-mmp: brownstone.c support multiple sd slots Philip Rakity
2011-02-14 14:10 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102141510.48137.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=markb@marvell.com \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox