From: Wolfram Sang <w.sang@pengutronix.de>
To: Zhu Richard-R65037 <R65037@freescale.com>
Cc: Zhao Richard-B20223 <B20223@freescale.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"cjb@laptop.org" <cjb@laptop.org>,
"avorontsov@ru.mvista.com" <avorontsov@ru.mvista.com>,
"eric@eukrea.com" <eric@eukrea.com>,
"linuxzsc@gmail.com" <linuxzsc@gmail.com>
Subject: Re: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO
Date: Mon, 21 Feb 2011 11:46:08 +0100 [thread overview]
Message-ID: <20110221104608.GF2616@pengutronix.de> (raw)
In-Reply-To: <010C9052C42A00499CE76D637FA5EE900C579F@039-SN1MPN1-001.039d.mgd.msft.net>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
> > > - if (cpu_is_mx35() || cpu_is_mx51())
> > > + if (cpu_is_mx53())
> > > + host->quirks |= SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO;
> >
> > Have you tried it doing it via IO-accessors?
> Richard Zhu: This quirk is used to fix a mechanism problem in the MMC CMDs execution procedure.
> It would be very abrupt and ugly, if the IO-accessors are added into these original procedures.
Please don't get it personal, but IMHO it is pretty ugly the way it is
now. This quirk is very imx-specific and calling something like
SDHCI_VENDOR_SPEC in sdhci.c looks clearly wrong to me. By the way, what
does this bit do, the description doesn't say so?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-02-21 10:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 9:54 [PATCH 1/5] ARM: imx53: add sdhc pad settings Richard Zhao
2011-02-21 9:54 ` [PATCH 2/5] ARM: imx51/53: add sdhc3/4 clock Richard Zhao
2011-02-21 16:21 ` Sascha Hauer
2011-02-22 2:16 ` Richard Zhao
2011-02-21 9:54 ` [PATCH 3/5] ARM: imx53_loco: add esdhc device support Richard Zhao
2011-02-21 9:54 ` [PATCH 4/5] mm: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS Richard Zhao
2011-02-21 10:02 ` Wolfram Sang
2011-02-21 9:54 ` [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO Richard Zhao
2011-02-21 10:04 ` Wolfram Sang
2011-02-21 10:18 ` Zhu Richard-R65037
2011-02-21 10:46 ` Wolfram Sang [this message]
2011-02-21 11:09 ` Russell King - ARM Linux
2011-02-21 11:15 ` Wolfram Sang
2011-02-22 2:21 ` Zhu Richard-R65037
2011-02-22 5:56 ` Zhu Richard-R65037
2011-02-22 2:26 ` Zhu Richard-R65037
2011-02-21 11:06 ` Russell King - ARM Linux
2011-02-21 12:26 ` Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221104608.GF2616@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=B20223@freescale.com \
--cc=R65037@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=cjb@laptop.org \
--cc=eric@eukrea.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxzsc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox