From: Wolfram Sang <w.sang@pengutronix.de>
To: Olof Johansson <olof@lixom.net>
Cc: Richard Zhu <Hong-Xing.Zhu@freescale.com>,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
linux-mmc@vger.kernel.org, cjb@laptop.org,
avorontsov@ru.mvista.com, eric@eukrea.com, linuxzsc@gmail.com,
richard.zhao@freescale.com
Subject: Re: [PATCH v2 5/5] mmc: sdhci-esdhc: enable esdhc on imx53
Date: Tue, 22 Feb 2011 16:51:30 +0100 [thread overview]
Message-ID: <20110222155130.GJ2755@pengutronix.de> (raw)
In-Reply-To: <AANLkTimbx6=YvRHFuVkmPVYvYtwME31PxXWNHNfFsVRQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
> > Thanks for respinning \o/ This approach looks better to me, but CCing
> > Olof to comment on abstraction issues if he has them. Will do a deeper
> > review later this week.
>
>
> I like it! Definitely the right approach. Pushing quirks down into the
> I/O accessors is definitely the only scalable way to handle all the
> various buggy controllers out there.
>
> Acked-by: Olof Johansson <olof@lixom.net>
Glad to hear that. I do have a few issues though, will report them later
as mentioned before, it needs a bit of time.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-02-22 15:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 10:13 [PATCH v2 1/5] ARM: imx53: add sdhc pad settings Richard Zhu
2011-02-22 10:13 ` [PATCH v2 2/5] ARM: imx51/53: add sdhc3/4 clock Richard Zhu
2011-02-23 7:50 ` Sascha Hauer
2011-02-23 14:43 ` Richard Zhao
2011-02-22 10:13 ` [PATCH v2 3/5] ARM: imx53_loco: add esdhc device support Richard Zhu
2011-02-22 10:13 ` [PATCH v2 4/5] mmc: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS Richard Zhu
2011-02-22 10:13 ` [PATCH v2 5/5] mmc: sdhci-esdhc: enable esdhc on imx53 Richard Zhu
2011-02-22 11:32 ` Wolfram Sang
2011-02-22 15:35 ` Olof Johansson
2011-02-22 15:51 ` Wolfram Sang [this message]
2011-02-24 6:16 ` Richard Zhao
2011-02-25 20:38 ` Wolfram Sang
2011-02-28 2:28 ` Zhu Richard-R65037
2011-02-28 9:05 ` Zhu Richard-R65037
2011-02-22 10:18 ` [PATCH v2 1/5] ARM: imx53: add sdhc pad settings Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222155130.GJ2755@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=Hong-Xing.Zhu@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=cjb@laptop.org \
--cc=eric@eukrea.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxzsc@gmail.com \
--cc=olof@lixom.net \
--cc=richard.zhao@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox