From: Chris Ball <cjb@laptop.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-mmc@vger.kernel.org, "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Subject: [PATCH v2 2/3] mmc: cb710: Return err value in cb710_wait_while_busy()
Date: Wed, 23 Feb 2011 23:17:43 +0000 [thread overview]
Message-ID: <20110223231743.GA30908@void.printf.net> (raw)
In-Reply-To: <20110223230309.GB15104@pengutronix.de>
Fixes:
drivers/mmc/host/cb710-mmc.c: In function ‘cb710_wait_while_busy’:
drivers/mmc/host/cb710-mmc.c:182:6: warning: variable ‘err’ set but not
used [-Wunused-but-set-variable]
Signed-off-by: Chris Ball <cjb@laptop.org>
Cc: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Cc: Wolfram Sang <w.sang@pengutronix.de>
---
Hi Wolfram,
> What about changing return 0 into return err? It gets checked in
> cb710_mmc_powerup().
Thanks, good idea.
- Chris.
drivers/mmc/host/cb710-mmc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/cb710-mmc.c b/drivers/mmc/host/cb710-mmc.c
index 66b4ce5..ce2a47b 100644
--- a/drivers/mmc/host/cb710-mmc.c
+++ b/drivers/mmc/host/cb710-mmc.c
@@ -205,7 +205,7 @@ static int cb710_wait_while_busy(struct cb710_slot *slot, uint8_t mask)
"WAIT12: waited %d loops, mask %02X, entry val %08X, exit val %08X\n",
limit, mask, e, x);
#endif
- return 0;
+ return err;
}
static void cb710_mmc_set_transfer_size(struct cb710_slot *slot,
--
1.7.0.1
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-02-23 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 22:29 [PATCH 1/3] mmc: sdhci-pci: Remove set-but-unused variable Chris Ball
2011-02-23 22:29 ` [PATCH 2/3] mmc: cb710: " Chris Ball
2011-02-23 23:03 ` Wolfram Sang
2011-02-23 23:17 ` Chris Ball [this message]
2011-02-24 8:40 ` [PATCH v2 2/3] mmc: cb710: Return err value in cb710_wait_while_busy() Wolfram Sang
2011-02-25 18:22 ` Michał Mirosław
2011-02-23 22:29 ` [PATCH 3/3] mmc: via-sdmmc: Remove set-but-unused variable Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223231743.GA30908@void.printf.net \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox