From: Wolfram Sang <w.sang@pengutronix.de>
To: Philip Rakity <prakity@marvell.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Jae hoon Chung <jh80.chung@gmail.com>,
Chuanxiao Dong <chuanxiao.dong@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sdhci: always use max timeout for xfers
Date: Fri, 25 Feb 2011 19:22:06 +0100 [thread overview]
Message-ID: <20110225182206.GC15491@pengutronix.de> (raw)
In-Reply-To: <9C437661-BFCC-4F73-989E-06589E0D37CA@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
> >> - return count;
> >> + return 0xE;
> >
> > Why don't you remove the function entirely?
>
> better to rename it --- to set_maximum_timeout since a little clearer.
> left the old name for historical reasons -- if no need I will change it
I'd suggest...
>
> >
> >> }
> >>
> >> static void sdhci_set_transfer_irqs(struct sdhci_host *host)
> >> @@ -671,7 +633,7 @@ static void sdhci_prepare_data(struct sdhci_host *host, struct mmc_data *data)
> >> host->data = data;
> >> host->data_early = 0;
> >>
> >> - count = sdhci_calc_timeout(host, data);
> >> + count = sdhci_calc_timeout();
> >> sdhci_writeb(host, count, SDHCI_TIMEOUT_CONTROL);
using SDHCI_TIMEOUT_MAX here instead of count with a proper define in
sdhci.h.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-02-25 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 17:54 [PATCH] sdhci: always use max timeout for xfers Philip Rakity
2011-02-25 18:02 ` Wolfram Sang
2011-02-25 18:12 ` Philip Rakity
2011-02-25 18:22 ` Wolfram Sang [this message]
2011-02-25 18:49 ` [PATCH V2] " Philip Rakity
2011-02-25 20:07 ` Wolfram Sang
2011-02-28 2:36 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110225182206.GC15491@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=chuanxiao.dong@intel.com \
--cc=jh80.chung@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox