Re: [PATCH] sdhci: always use max timeout for xfers

Wolfram Sang
2011-02-25T18:22:14Z

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

> >> - return count;
> >> + return 0xE;
> >
> > Why don't you remove the function entirely?
>
> better to rename it --- to set_maximum_timeout since a little clearer.
> left the old name for historical reasons -- if no need I will change it

I'd suggest...

>
> >
> >> }
> >>
> >> static void sdhci_set_transfer_irqs(struct sdhci_host *host)
> >> @@ -671,7 +633,7 @@ static void sdhci_prepare_data(struct sdhci_host *host, struct mmc_data *data)
> >> host->data = data;
> >> host->data_early = 0;
> >>
> >> - count = sdhci_calc_timeout(host, data);
> >> + count = sdhci_calc_timeout();
> >> sdhci_writeb(host, count, SDHCI_TIMEOUT_CONTROL);

using SDHCI_TIMEOUT_MAX here instead of count with a proper define in
sdhci.h.

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]