From: Paul Mundt <lethal@linux-sh.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org,
Chris Ball <cjb@laptop.org>, Ian Molton <ian@mnementh.co.uk>
Subject: Re: [PATCH 2/5] mmc: tmio: add a flag to prohibit access to registers above 0xff
Date: Tue, 8 Mar 2011 16:34:34 +0900 [thread overview]
Message-ID: <20110308073434.GB13892@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1103071944200.29543@axis700.grange>
On Mon, Mar 07, 2011 at 07:47:51PM +0100, Guennadi Liakhovetski wrote:
> On some implementations there are no registers above 0xff and any
> access to them mirrors to registers at addresses with bit 8 masked
> out, which leads to malfunction. Add a flag to prevent such accesses.
I'm not sure I really see what the point of the flag is, surely you can
derive all of this information already from the I/O resource for the
register window in question?
next prev parent reply other threads:[~2011-03-08 7:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 18:47 [PATCH 0/5] tmio PM: aggressive clock gating, register layout limitation Guennadi Liakhovetski
2011-03-07 18:47 ` [PATCH/RFC 1/5] mmc: tmio: fix power-mode interpretation Guennadi Liakhovetski
2011-03-07 18:47 ` [PATCH 2/5] mmc: tmio: add a flag to prohibit access to registers above 0xff Guennadi Liakhovetski
2011-03-08 3:35 ` Magnus Damm
2011-03-08 7:34 ` Paul Mundt [this message]
2011-03-07 18:47 ` [PATCH 3/5] ARM: mach-shmobile: use the new TMIO_MMC_HI_REGS_MISSING flag for SDHI Guennadi Liakhovetski
2011-03-07 18:47 ` [PATCH 4/5] sh: " Guennadi Liakhovetski
2011-03-07 18:48 ` [PATCH/RFC 5/5] mmc: tmio: support aggressive clock gating Guennadi Liakhovetski
2011-03-08 8:42 ` [PATCH 0/5] tmio PM: aggressive clock gating, register layout limitation Paul Mundt
2011-03-08 9:29 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308073434.GB13892@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=ian@mnementh.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox