From: Wolfram Sang <w.sang@pengutronix.de>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] mmc: sdhci: add error checking for mmc_add_host
Date: Mon, 4 Apr 2011 05:47:53 +0200 [thread overview]
Message-ID: <20110404034753.GA1428@pengutronix.de> (raw)
In-Reply-To: <4D993199.1060206@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Mon, Apr 04, 2011 at 11:48:57AM +0900, Jaehoon Chung wrote:
> Sometimes we can't add the device,but we didn't check any error status.
> Need to check error status for mmc_add_host.
Thanks, this is correct, but...
> - mmc_add_host(mmc);
> + ret = mmc_add_host(mmc);
> + if (unlikely(ret))
> + goto err_free_mmc;
... you are leaking the irq and the lcd_classdev here.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-04-04 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 2:48 [PATCH] mmc: sdhci: add error checking for mmc_add_host Jaehoon Chung
2011-04-04 3:47 ` Wolfram Sang [this message]
2011-04-04 4:13 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404034753.GA1428@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox