From: Wolfram Sang <w.sang@pengutronix.de>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] mmc: sdhci: fixed regulator control when suspend/resume
Date: Fri, 8 Apr 2011 20:47:10 +0200 [thread overview]
Message-ID: <20110408184710.GC23883@pengutronix.de> (raw)
In-Reply-To: <4D9D3C58.5030901@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
On Thu, Apr 07, 2011 at 01:23:52PM +0900, Jaehoon Chung wrote:
> Suspend/resume is working always enable regulator after resuming.
> (if there is host->vmmc)
The regulator is enabled during add_host. How could it not be enabled in
suspend?
> struct regulator *vmmc; /* Power regulator */
> + bool restore_vmmc; /* Restore vmmc */
If you can explain the above, this should be turned into a SDHCI_-flag IMHO.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-04-08 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 4:23 [PATCH] mmc: sdhci: fixed regulator control when suspend/resume Jaehoon Chung
2011-04-08 18:47 ` Wolfram Sang [this message]
2011-04-09 11:44 ` Jae hoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408184710.GC23883@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).