From: Arnd Bergmann <arnd@arndb.de>
To: John Calixto <john.calixto@modsystems.com>
Cc: "Michał Mirosław" <mirqus@gmail.com>,
linux-mmc@vger.kernel.org, "Chris Ball" <cjb@laptop.org>,
"Andrei Warkentin" <andreiw@motorola.com>
Subject: Re: [PATCH v4] mmc: Add ioctl to let userspace apps send ACMDs
Date: Mon, 18 Apr 2011 16:39:48 +0200 [thread overview]
Message-ID: <201104181639.48730.arnd@arndb.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1104121604220.8483@peruna>
On Wednesday 13 April 2011, John Calixto wrote:
> Gah! OK, so much for the v5 I just sent then. What do you think about
> the compat_ioctl that I sent in v2? It means having the extra 32-bit
> compat structure, but at least all the compat overhead is conditional
> upon CONFIG_COMPAT. If you're not using CONFIG_COMPAT, you don't get
> any compat cruft.
>
A single __u64 is sufficient, because the user space will do the correct
conversion from pointer to 64-bit integer then. The only conversion
you need to worry about is the actual pointer to the main structure,
which needs the compat_ptr() magic.
Arnd
next prev parent reply other threads:[~2011-04-18 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 21:47 mmc: Add ioctl to let userspace apps send ACMDs John Calixto
2011-04-11 21:55 ` [PATCH v4] " John Calixto
2011-04-12 14:21 ` Michał Mirosław
2011-04-12 21:51 ` John Calixto
2011-04-12 23:00 ` Arnd Bergmann
2011-04-12 23:08 ` John Calixto
2011-04-18 14:39 ` Arnd Bergmann [this message]
2011-04-18 16:30 ` John Calixto
2011-04-12 23:10 ` Arnd Bergmann
2011-04-12 23:40 ` John Calixto
2011-04-18 14:42 ` Arnd Bergmann
2011-04-18 16:37 ` John Calixto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104181639.48730.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andreiw@motorola.com \
--cc=cjb@laptop.org \
--cc=john.calixto@modsystems.com \
--cc=linux-mmc@vger.kernel.org \
--cc=mirqus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox