From: Greg KH <greg@kroah.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: gregkh@suse.de, maximlevitsky@gmail.com,
linux-mmc@vger.kernel.org, david-b@pacbell.net,
stern@rowland.harvard.edu, stable-commits@vger.kernel.org,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
stable@kernel.org
Subject: Re: [stable] Patch "mmc: fix all hangs related to mmc/sd card insert/removal during suspend/resume" has been added to the 2.6.32-longterm tree
Date: Mon, 9 May 2011 13:46:43 -0700 [thread overview]
Message-ID: <20110509204643.GD1432@kroah.com> (raw)
In-Reply-To: <BANLkTi=gQnAUOGZ-FOxmcyrDaffxUVF9+w@mail.gmail.com>
On Fri, May 06, 2011 at 09:37:46AM +0300, Ohad Ben-Cohen wrote:
> On Fri, May 6, 2011 at 12:54 AM, <gregkh@suse.de> wrote:
> >
> > This is a note to let you know that I've just added the patch titled
> >
> > mmc: fix all hangs related to mmc/sd card insert/removal during suspend/resume
> >
> > to the 2.6.32-longterm tree
>
> That patch introduced a suspend/resume regression, so please also add
> the one that fixed it:
>
> commit 1c8cf9c997a4a6b36e907c7ede5f048aeaab1644
> Author: Ohad Ben-Cohen <ohad@wizery.com>
> Date: Wed Oct 13 09:31:56 2010 +0200
>
> mmc: sdio: fix SDIO suspend/resume regression
>
> Fix SDIO suspend/resume regression introduced by 4c2ef25fe0b "mmc: fix
> all hangs related to mmc/sd card insert/removal during suspend/resume":
>
> PM: Syncing filesystems ... done.
> Freezing user space processes ... (elapsed 0.01 seconds) done.
> Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
> Suspending console(s) (use no_console_suspend to debug)
> pm_op(): platform_pm_suspend+0x0/0x5c returns -38
> PM: Device pxa2xx-mci.0 failed to suspend: error -38
> PM: Some devices failed to suspend
>
> 4c2ef25fe0b moved the card removal/insertion mechanism out of MMC's
> suspend/resume path and into pm notifiers (mmc_pm_notify), and that
> broke SDIO's expectation that mmc_suspend_host() will remove the card,
> and squash the error, in case -ENOSYS is returned from the bus suspend
> handler (mmc_sdio_suspend() in this case).
>
> mmc_sdio_suspend() is using this whenever at least one of the card's SDIO
> function drivers does not have suspend/resume handlers - in that case
> it is agreed to force removal of the entire card.
>
> This patch fixes this regression by trivially bringing back that part of
> mmc_suspend_host(), which was removed by 4c2ef25fe0b.
>
> Reported-and-tested-by: Sven Neumann <s.neumann@raumfeld.com>
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: Maxim Levitsky <maximlevitsky@gmail.com>
> Cc: <stable@kernel.org>
> Acked-by: Nicolas Pitre <nico@fluxnic.net>
> Signed-off-by: Chris Ball <cjb@laptop.org>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2011-05-09 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 21:54 Patch "mmc: fix all hangs related to mmc/sd card insert/removal during suspend/resume" has been added to the 2.6.32-longterm tree gregkh
2011-05-06 6:37 ` Ohad Ben-Cohen
2011-05-09 20:46 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509204643.GD1432@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=linux-mmc@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=ohad@wizery.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).