linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@freescale.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>,
	linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org,
	devicetree-discuss@lists.ozlabs.org,
	Olof Johansson <olof@lixom.net>,
	Saeed Bishara <saeed@marvell.com>,
	Mike Rapoport <mike@compulab.co.il>,
	Anton Vorontsov <avorontsov@ru.mvista.com>,
	Xiaobo Xie <X.Xie@freescale.com>,
	Albert Herranz <albert_herranz@yahoo.es>,
	Grant Likely <grant.likely@secretlab.ca>,
	Arnd Bergmann <arnd@arndb.de>,
	kernel@pengutronix.de, sameo@linux.intel.com,
	Chris Ball <cjb@laptop.org>,
	patches@linaro.org
Subject: Re: [PATCH v2 0/7] Consolidate sdhci pltfm & OF drivers and get them self registered
Date: Fri, 20 May 2011 00:09:02 +0800	[thread overview]
Message-ID: <20110519160901.GC26816@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <20110519094046.GA2219@pengutronix.de>

Hi Wolfram,

On Thu, May 19, 2011 at 11:40:46AM +0200, Wolfram Sang wrote:
> Hi Shawn,
> 
> > Changes since v1:
> >  * Rebase on cjb's mmc-next tree
> 
> Is it maybe possible that you get access to
> http://opensource.freescale.com/git or another machine? A branch to pull
> from would be more convenient, because the series does not apply to
> mmc-next anymore, so an extra step to go "back in time" is needed.
> 
> (minor) When applying I got:
> 
> Applying: mmc: sdhci: make sdhci-pltfm device drivers self registered
> /home/wsa/Kernel/linux-2.6/.git/rebase-apply/patch:384: trailing whitespace.
> /home/wsa/Kernel/linux-2.6/.git/rebase-apply/patch:817: space before tab in indent.
>  	struct tegra_sdhci_platform_data *plat;
> /home/wsa/Kernel/linux-2.6/.git/rebase-apply/patch:867: trailing whitespace.
> 
> Applying: sdhci: rename sdhci-esdhc-imx.c to sdhci-esdhc.c
> /home/wsa/Kernel/linux-2.6/.git/rebase-apply/patch:780: trailing whitespace.
> 
> See later comments for further issues.
> 
Should I go for v3 right now to address the patch applying problems
and that ESDHC_IMX build issue, or hold for a while to see if you
have more comments on v2?

And what is your position on patch #5 which merges esdhc imx and mpc
support into one?  As Anton has voted a NO there, I would probably
drop the patch if there is another person has strong opinion to get
imx and mpc stay separated.

-- 
Regards,
Shawn


  reply	other threads:[~2011-05-19 16:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05 13:22 [PATCH v2 0/7] Consolidate sdhci pltfm & OF drivers and get them self registered Shawn Guo
2011-05-05 13:22 ` [PATCH v2 1/7] mmc: sdhci: make sdhci-pltfm device drivers " Shawn Guo
2011-05-05 14:24   ` Anton Vorontsov
     [not found] ` <1304601778-13837-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-05-05 13:22   ` [PATCH v2 2/7] mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data Shawn Guo
2011-05-05 14:23     ` Anton Vorontsov
2011-05-24 19:26     ` Wolfram Sang
2011-05-05 13:22 ` [PATCH v2 3/7] mmc: sdhci: make sdhci-of device drivers self registered Shawn Guo
2011-05-05 14:23   ` Anton Vorontsov
2011-05-06  2:15     ` Shawn Guo
2011-05-24 19:32   ` Wolfram Sang
2011-05-05 13:22 ` [PATCH v2 4/7] sdhci: rename sdhci-esdhc-imx.c to sdhci-esdhc.c Shawn Guo
2011-05-05 13:22 ` [PATCH v2 5/7] mmc: sdhci: consolidate sdhci-of-esdhc and sdhci-esdhc-imx Shawn Guo
2011-05-05 14:20   ` Anton Vorontsov
2011-05-19  9:48   ` Wolfram Sang
2011-05-24 19:40   ` Wolfram Sang
2011-05-25  6:06     ` Shawn Guo
2011-05-25  6:46       ` Uwe Kleine-König
2011-05-25  9:36         ` Shawn Guo
2011-05-05 13:22 ` [PATCH v2 6/7] mmc: sdhci: merge two sdhci-pltfm.h into one Shawn Guo
2011-05-05 14:13   ` Anton Vorontsov
2011-05-05 13:22 ` [PATCH v2 7/7] ARM: mxc: remove esdhc.h and use the public one Shawn Guo
2011-05-06  8:39   ` Uwe Kleine-König
2011-05-09  6:23     ` Shawn Guo
2011-05-19  9:40 ` [PATCH v2 0/7] Consolidate sdhci pltfm & OF drivers and get them self registered Wolfram Sang
2011-05-19 16:09   ` Shawn Guo [this message]
2011-05-19 17:05     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110519160901.GC26816@S2100-06.ap.freescale.net \
    --to=shawn.guo@freescale.com \
    --cc=X.Xie@freescale.com \
    --cc=albert_herranz@yahoo.es \
    --cc=arnd@arndb.de \
    --cc=avorontsov@ru.mvista.com \
    --cc=cjb@laptop.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mike@compulab.co.il \
    --cc=olof@lixom.net \
    --cc=patches@linaro.org \
    --cc=saeed@marvell.com \
    --cc=sameo@linux.intel.com \
    --cc=shawn.guo@linaro.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).