From: Arnd Bergmann <arnd@arndb.de>
To: Zhangfei Gao <zhangfei.gao@marvell.com>
Cc: Nicolas Pitre <nico@fluxnic.net>,
Philip Rakity <prakity@marvell.com>,
Wolfram Sang <w.sang@pengutronix.de>, Chris Ball <cjb@laptop.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Jun Nie <njun@marvell.com>, Raymond Wu <xywu@marvell.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Mark Brown <mark.brown314@gmail.com>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH] mmc: support sdhci-mmp2
Date: Mon, 23 May 2011 17:01:38 +0200 [thread overview]
Message-ID: <201105231701.38198.arnd@arndb.de> (raw)
In-Reply-To: <1306156882-12124-1-git-send-email-zhangfei.gao@marvell.com>
On Monday 23 May 2011, Zhangfei Gao wrote:
> Delete sdhci-pxa.c and replace with sdhci-mmp2.c specificlly for mmp2
>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@marvell.com>
> ---
> arch/arm/plat-pxa/include/plat/sdhci.h | 43 ++++-
> drivers/mmc/host/Kconfig | 9 +-
> drivers/mmc/host/Makefile | 2 +-
> drivers/mmc/host/sdhci-mmp2.c | 304 ++++++++++++++++++++++++++++++++
> drivers/mmc/host/sdhci-pxa.c | 303 -------------------------------
> 5 files changed, 349 insertions(+), 312 deletions(-)
> create mode 100644 drivers/mmc/host/sdhci-mmp2.c
> delete mode 100644 drivers/mmc/host/sdhci-pxa.c
Hi Zhangfei,
You should really try to improve your changelog texts. Instead of
the one-line summary that describes what you do 'Delete sdhci-pxa.c and
replace ...', please provide a paragraph explaining why you do it,
and what the bigger plan is here.
Also, when renaming a file, please use 'git diff -M' or 'git format-patch -M'
to detect renames and generate a diff for the changes you did to the file.
Arnd
next prev parent reply other threads:[~2011-05-23 15:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 13:21 [PATCH] mmc: support sdhci-mmp2 Zhangfei Gao
2011-05-23 15:01 ` Arnd Bergmann [this message]
2011-05-25 8:41 ` zhangfei gao
2011-05-24 6:10 ` Philip Rakity
2011-05-25 8:50 ` zhangfei gao
2011-05-28 5:00 ` Philip Rakity
2011-05-28 8:52 ` Arnd Bergmann
2011-05-28 16:25 ` Philip Rakity
2011-05-28 19:04 ` Arnd Bergmann
2011-05-30 13:15 ` zhangfei gao
2011-05-30 20:47 ` Philip Rakity
2011-05-31 12:07 ` zhangfei gao
2011-05-31 15:57 ` Philip Rakity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105231701.38198.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.brown314@gmail.com \
--cc=nico@fluxnic.net \
--cc=njun@marvell.com \
--cc=prakity@marvell.com \
--cc=shawn.guo@linaro.org \
--cc=w.sang@pengutronix.de \
--cc=xywu@marvell.com \
--cc=zhangfei.gao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox