From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] ARM: OMAP4: MMC: no regulator off during probe for eMMC Date: Tue, 31 May 2011 06:26:15 -0700 Message-ID: <20110531132614.GR11352@atomide.com> References: <1306765534-20103-1-git-send-email-balajitk@ti.com> <1306765534-20103-3-git-send-email-balajitk@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:23245 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752847Ab1EaN0S (ORCPT ); Tue, 31 May 2011 09:26:18 -0400 Content-Disposition: inline In-Reply-To: <1306765534-20103-3-git-send-email-balajitk@ti.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Balaji T K Cc: linux-omap@vger.kernel.org, cjb@laptop.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, madhu.cr@ti.com * Balaji T K [110530 07:23]: > eMMC does not handle power off when not in sleep state, > Skip regulator disable during probe when eMMC is > not in known state - state left by bootloader. > > Resolves eMMC failure on OMAP4 > mmc0: error -110 whilst initialising MMC card > > --- a/arch/arm/mach-omap2/hsmmc.h > +++ b/arch/arm/mach-omap2/hsmmc.h > @@ -18,6 +18,7 @@ struct omap2_hsmmc_info { > bool nonremovable; /* Nonremovable e.g. eMMC */ > bool power_saving; /* Try to sleep or power off when possible */ > bool no_off; /* power_saving and power is not to go off */ > + bool no_off_init; /* no power off when not in MMC sleep state */ > bool vcc_aux_disable_is_sleep; /* Regulator off remapped to sleep */ > int gpio_cd; /* or -EINVAL */ > int gpio_wp; /* or -EINVAL */ Can't you use no_off for this too? Tony