From: Wolfram Sang <w.sang@pengutronix.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, cbouatmailru@gmail.com,
cjb@laptop.org, grant.likely@secretlab.ca, arnd@arndb.de,
sfr@canb.auug.org.au, patches@linaro.org,
Shawn Guo <shawn.guo@freescale.com>
Subject: Re: [PATCH] mmc: sdhci: change sdhci-pltfm into a module
Date: Sun, 5 Jun 2011 08:56:39 +0200 [thread overview]
Message-ID: <20110605065638.GA30268@pengutronix.de> (raw)
In-Reply-To: <1306983470-18588-1-git-send-email-shawn.guo@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1482 bytes --]
On Thu, Jun 02, 2011 at 10:57:50AM +0800, Shawn Guo wrote:
> From: Shawn Guo <shawn.guo@freescale.com>
>
> There are a couple of problems left from the sdhci pltfm and OF
> consolidation changes.
>
> * When building more than one sdhci-pltfm based drivers in the same
> image, linker will give multiple definition error on the sdhci-pltfm
> helper functions. For example right now, building sdhci-of-esdhc
> and sdhci-of-hlwd together is a valid combination from Kconfig view.
>
> * With the current build method, there is error with building the
> drivers as module, but module installation fails with modprobe.
>
> The patch fixes above problems by changing sdhci-pltfm into a module.
> To avoid EXPORT_SYMBOL on so many big endian IO accessors, it moves
> these accessors into sdhci-pltfm.h as the 'static inline' functions.
> As a result, sdhci.h needs to be included in sdhci-pltfm.h, and in
> turn can be removed from individual drivers which already include
> sdhci-pltfm.h.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
I am a bit confused how to review this patch and patch 1/4 from Shawn's
original series. As Chris does rebase his mmc-next anyway, does it make sense
to squash this into the old ones to prevent the broken inbetween state?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2011-06-05 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110601130431.59f4f0d4.sfr@canb.auug.org.au>
2011-06-02 2:57 ` [PATCH] mmc: sdhci: change sdhci-pltfm into a module Shawn Guo
2011-06-03 20:03 ` Grant Likely
2011-06-04 12:08 ` Shawn Guo
2011-06-05 6:56 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110605065638.GA30268@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=arnd@arndb.de \
--cc=cbouatmailru@gmail.com \
--cc=cjb@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sfr@canb.auug.org.au \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox