Re: [PATCH 1/2] mmc: sdhci: Replace SDHCI_QUIRK_FORCE_BLK_SZ_2048 with a platform hook.

[Wolfram Sang <w.sang@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

Hi Nicolas,

> > > :( I still like the io-accessor-method a lot better.
> > 
> > That's okay -- nothing's final yet, I just wanted to get things moving
> > again since we're out of quirk space now.  I'm still happy to take a
> > patch from you instead if we decide it's the better way to go.
> 
> What about letting the platform specific code override the caps bits 
> instead?  That would work for many other things as well, like the 
> various DMA quirks, etc.  And that requires only one callback instead of 
> one per parameter you might want to override.
> 
> This should be made explicit with a dedicated callback of course, not 
> via some magic in sdhci_readl() please.

I proposed a kind-of fixup() function once, but someone (Olof?) didn't like it
because it broke abstraction. However, after Shawn's patch series turning sdhci
into a library, things might have become easier for this approach. Hmmm, I'd
like to try it, just have to see when.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]