From: Wolfram Sang <w.sang@pengutronix.de>
To: Sebastian Rasmussen <sebras@gmail.com>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/3] MMC: Fix checkpatch errors
Date: Sun, 19 Jun 2011 08:43:29 +0200 [thread overview]
Message-ID: <20110619064329.GA1632@pengutronix.de> (raw)
In-Reply-To: <1308419423-18234-1-git-send-email-sebras@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2218 bytes --]
On Sat, Jun 18, 2011 at 07:50:23PM +0200, Sebastian Rasmussen wrote:
Please state in the commit-msg what kind of errors have been fixed.
They all seem to be whitespace related issues. Have you checked that the
binaries are identical before and after your patch? That could also go into the
commit-msg.
> Signed-off-by: Sebastian Rasmussen <sebras@gmail.com>
> ---
> drivers/mmc/card/block.c | 14 ++++++--------
> drivers/mmc/card/mmc_test.c | 34 +++++++++++++++++-----------------
> drivers/mmc/card/queue.c | 14 +++++++-------
> drivers/mmc/core/core.c | 2 +-
> drivers/mmc/core/mmc.c | 2 +-
> drivers/mmc/core/mmc_ops.c | 4 ++--
> drivers/mmc/core/sd.c | 2 +-
> drivers/mmc/core/sd_ops.c | 4 ++--
> drivers/mmc/core/sdio.c | 4 ++--
> drivers/mmc/core/sdio_bus.c | 2 +-
> drivers/mmc/core/sdio_cis.c | 18 ++++++++++--------
> drivers/mmc/core/sdio_ops.h | 2 +-
> 12 files changed, 51 insertions(+), 51 deletions(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 71da564..1c7049a 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -908,10 +908,10 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *req)
> return 1;
>
> cmd_err:
> - /*
> - * If this is an SD card and we're writing, we can first
> - * mark the known good sectors as ok.
> - *
> + /*
> + * If this is an SD card and we're writing, we can first
> + * mark the known good sectors as ok.
> + *
> * If the card is not SD, we can still ok written sectors
> * as reported by the controller (which might be less than
> * the real number of written sectors, but never more).
> @@ -1003,8 +1003,7 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card,
> if (!subname) {
> md->name_idx = find_first_zero_bit(name_use, max_devices);
> __set_bit(md->name_idx, name_use);
> - }
> - else
> + } else
else-block needs braces.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2011-06-19 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 17:50 [PATCH 1/3] MMC: Fix checkpatch errors Sebastian Rasmussen
2011-06-19 6:43 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110619064329.GA1632@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-mmc@vger.kernel.org \
--cc=sebras@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox