From: Arnd Bergmann <arnd@arndb.de>
To: zhangfei gao <zhangfei.gao@gmail.com>
Cc: Zhangfei Gao <zhangfei.gao@marvell.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3
Date: Mon, 20 Jun 2011 13:49:38 +0200 [thread overview]
Message-ID: <201106201349.38459.arnd@arndb.de> (raw)
In-Reply-To: <BANLkTi=_qEQT5f_FcAEYz2Y5p6FGJU+P5Q@mail.gmail.com>
On Monday 20 June 2011, zhangfei gao wrote:
> Currently, clk_enable, clk_disable, clk_get_rate realization are
> located at arch.
> Driver/clk/clkdev.c only realize clk_get/put.
>
> I am afraid it may difficult to build the driver on other arch, like
> x86, so we may still need "depends on ARCH_MMP" for safety.
I would recommend turning this into "depends on CLKDEV_LOOKUP" instead.
Always be specific with your dependencies so you enable the option
on all platforms that are able to build it, but not on any of the
others.
Arnd
next prev parent reply other threads:[~2011-06-20 11:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 6:44 [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3 Zhangfei Gao
2011-06-20 8:07 ` Arnd Bergmann
2011-06-20 9:36 ` zhangfei gao
2011-06-20 10:02 ` zhangfei gao
2011-06-20 10:26 ` zhangfei gao
2011-06-20 11:49 ` Arnd Bergmann [this message]
2011-06-20 13:23 ` zhangfei gao
2011-06-20 13:25 ` Arnd Bergmann
2011-06-20 11:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106201349.38459.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=zhangfei.gao@gmail.com \
--cc=zhangfei.gao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox