From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Ram Pai <linuxram@us.ibm.com>
Cc: jbarnes@virtuousgeek.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, svenkatr@ti.com, yinghai@kernel.org,
cjb@laptop.org, linux-pci@vger.kernel.org,
linux-net-drivers@solarflare.com, bhutchings@solarflare.com
Subject: Re: [PATCH 4/4] PCI: make cardbus-bridge resources nice-to-have
Date: Tue, 21 Jun 2011 09:57:00 +0200 [thread overview]
Message-ID: <20110621075659.GA4620@comet.dominikbrodowski.net> (raw)
In-Reply-To: <1308610037-6261-5-git-send-email-linuxram@us.ibm.com>
On Mon, Jun 20, 2011 at 03:47:17PM -0700, Ram Pai wrote:
> Allocate resources to cardbus bridge only after all other genuine
> resources requests are satisfied. Dont retry if resource allocation
> for cardbus-bridge fails.
Well, for those who use cardbus cards, cardbus resources aren't "nice to
have", they are absolutely required. Of course, not all cardbus cards need
as many resources as are currently assigned, so I wouldn't oppose a patch
which marks _some_ of the currently assigned resources as "nice to have".
But this approach -- 0 required, all "nice to have" -- seems wrong to me.
Best,
Dominik
next prev parent reply other threads:[~2011-06-21 7:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 22:47 [PATCH 0/4] PCI: fix cardbus and sriov regressions Ram Pai
2011-06-20 22:47 ` [PATCH 1/4] PCI: honor child buses add_size in hot plug configuration Ram Pai
2011-06-20 22:47 ` [PATCH 2/4] PCI : ability to resize assigned pci-resource Ram Pai
2011-06-20 22:47 ` [PATCH 3/4] PCI: make SRIOV resources nice-to-have Ram Pai
2011-06-20 22:47 ` [PATCH 4/4] PCI: make cardbus-bridge " Ram Pai
2011-06-21 7:57 ` Dominik Brodowski [this message]
2011-06-21 16:23 ` Ram Pai
2011-06-21 18:50 ` Jesse Barnes
2011-06-21 21:36 ` Jesse Barnes
2011-06-21 22:13 ` Dominik Brodowski
2011-06-22 0:48 ` Ram Pai
2011-06-23 20:31 ` Jesse Barnes
2011-06-23 20:42 ` Rafael J. Wysocki
2011-06-24 16:28 ` Ram Pai
2011-06-24 23:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621075659.GA4620@comet.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=bhutchings@solarflare.com \
--cc=cjb@laptop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=svenkatr@ti.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox