Re: [PATCH] mmc: sdhci: fix retuning timer wrongly deleted in sdhci_tasklet_finish

[Aaron Lu <aaron.lu@amd.com>]

On Thu, Jul 21, 2011 at 05:35:02PM +0800, zhangfei gao wrote:
> 
> Does the execute_tuning is called again?
> del_timer is not delete timer really, but deactivate the timer, which
> could be re-activated by mod_timer.
> So if execute_tuning is called, the mod_timer will tigger the tuning
> timer again.
>

Hi zhangfei,

Thanks for the comment.

The execute_tuning will be called at two places:
1 In mmc_sd_init_uhs_card, when host is initializing an UHS card,
and the re-tuning timer will be activated for the first time;
2 When re-tuning timer expired

So if the re-tuning timer is deactivated in sdhci_tasklet_finish,
execute_tuning will have no chance of getting called again, and the
host will not be able to do the re-tuning anymore.
 
> >> >
> >> > Signed-off-by: Aaron Lu <Aaron.Lu@amd.com>
> >> > ---
> >> >  drivers/mmc/host/sdhci.c |    3 ---
> >> >  1 files changed, 0 insertions(+), 3 deletions(-)
> >> >
> >> > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> >> > index 91d9892..6250bac 100644
> >> > --- a/drivers/mmc/host/sdhci.c
> >> > +++ b/drivers/mmc/host/sdhci.c
> >> > @@ -1863,9 +1863,6 @@ static void sdhci_tasklet_finish(unsigned long
> >> > param)
> >> >
> >> >     del_timer(&host->timer);
> >> >
> >> > -   if (host->version >= SDHCI_SPEC_300)
> >> > -           del_timer(&host->tuning_timer);
> >> > -
> >> >     mrq = host->mrq;
> >> >
> >> >     /*
> >> > --
> >> > 1.7.1
> >>
> >>
> >
> >
>