Re: [PATCH v2 1/6] arm: davinci: Fix low level gpio irq handlers' argument

Ido Yariv
2011-07-11T20:34:07Z

Hi Sekhar,

On Mon, Jul 11, 2011 at 05:28:44PM +0530, Nori, Sekhar wrote:
> Thanks for the bug fix.
>
> How about setting the handler data for bank IRQ in
> davinci_gpio_irq_setup() to &chips[bank]?
>
> chips[bank].regs should give you the register base address
> (g) and chips[bank].irq_base should give you 'n'.
>
> Also please drop the rename of irq to bank_irq as it is not
> central to the bug fix.
>
> If you spin in soon enough, we may make it to v3.0

Sure, I'll send a v3 in a few.

Thanks for the review,
Ido.