Re: [PATCH 1/3] irq: If an IRQ is a GPIO, request and configure it

Mark Brown
2011-08-05T00:01:50Z

On Thu, Aug 04, 2011 at 05:00:18PM -0600, Stephen Warren wrote:

> + } else {
> + gpio = irq_to_gpio(irq);
> + if (gpio_is_valid(gpio)) {
> + ret = gpio_request(gpio, new->name);
> + if (ret < 0)
> + goto out_mask;
> + ret = gpio_direction_input(gpio);
> + if (ret < 0)
> + goto out_mask;
> + }

If you treat failures as an error what happens when a driver is using a
GPIO as both an interrupt and a GPIO? For example a driver which
monitors the level on a GPIO and uses edge triggered IRQs to be notified
of state changes.