From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Zang Roy-R61911 <r61911@freescale.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
Xu Lei-B33228 <B33228@freescale.com>,
Kumar Gala <galak@kernel.crashing.org>,
Wood Scott-B07421 <B07421@freescale.com>
Subject: Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc
Date: Fri, 12 Aug 2011 14:04:50 +0400 [thread overview]
Message-ID: <20110812100450.GA23333@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <2239AC579C7D3646A720227A37E0268118FD3B@039-SN1MPN1-005.039d.mgd.msft.net>
Hello,
On Fri, Aug 12, 2011 at 09:44:26AM +0000, Zang Roy-R61911 wrote:
[...]
> > We try to not pollute generic sdhci.c driver with chip-specific
> > quirks.
> >
> > Maybe you can do the fixups via IO accessors? Or by introducing
> > some additional sdhci op?
> Anton,
> thanks for the comment, as we discussed, the original code use 8 bit byte operation,
> while in fact, on some powerpc platform, 32 bit operation is needed.
> should it be possible fixed by adding some wrapper in IO accessors or introduce additional sdhci op?
I would do it in the IO accessors.
Thanks,
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2011-08-12 10:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 10:15 [PATCH 1/2 v2] eSDHC: Access Freescale eSDHC registers by 32-bit Roy Zang
2011-07-22 10:15 ` [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc Roy Zang
2011-07-22 10:15 ` Anton Vorontsov
2011-07-26 10:29 ` Zang Roy-R61911
2011-08-12 9:44 ` Zang Roy-R61911
2011-08-12 10:04 ` Anton Vorontsov [this message]
2011-08-15 4:46 ` Zang Roy-R61911
2011-08-26 8:44 ` Zang Roy-R61911
2011-09-09 9:03 ` Zang Roy-R61911
2011-09-09 9:07 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812100450.GA23333@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=B07421@freescale.com \
--cc=B33228@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=galak@kernel.crashing.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r61911@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox