From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating Date: Thu, 18 Aug 2011 13:34:41 +0300 Message-ID: <20110818103441.GX16790@intel.com> References: <20110817121914.GW16790@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga14.intel.com ([143.182.124.37]:58468 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755228Ab1HRKeI (ORCPT ); Thu, 18 Aug 2011 06:34:08 -0400 Content-Disposition: inline In-Reply-To: <20110817121914.GW16790@intel.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Linus Walleij Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, cjb@laptop.org On Wed, Aug 17, 2011 at 03:19:14PM +0300, Mika Westerberg wrote: > On Wed, Aug 17, 2011 at 09:51:31AM +0200, Linus Walleij wrote: > > > > I would suggest that in all patches using these functions, try > > to replace: > > > > mmc_host_clk_disable() -> mmc_host_clk_ungate() > > mmc_host_clk_enable() -> mmc_host_clk_gate() > > > > Wow, that is indeed *much* cleaner way of doing this! > > One thing is that if I call these from those ios functions, > mmc_host_clk_ungate() will always try to restore the clock > even if there is really no need. Do you see this as a problem? > > > Please tell us if this works! > > Certainly. I'll try this overnight and see whether it works. The device survived overnight reboot loop test, so this scheme seems to work. I'll prepare a new series which uses mmc_host_clk_{ungate|gate}().