public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org,
	Paul Mundt <lethal@linux-sh.org>,
	Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH] [RFC] ARM: shmobile: g4evm: Use multiple irq vectors for SDHI
Date: Tue, 30 Aug 2011 12:45:28 +0900	[thread overview]
Message-ID: <20110830034528.GA31103@verge.net.au> (raw)
In-Reply-To: <20110826130642.GA13205@verge.net.au>

On Fri, Aug 26, 2011 at 10:06:45PM +0900, Simon Horman wrote:
> On Fri, Aug 26, 2011 at 02:56:50PM +0200, Guennadi Liakhovetski wrote:
> > On Fri, 26 Aug 2011, Simon Horman wrote:
> > 
> > > On Fri, Aug 26, 2011 at 02:17:20PM +0200, Guennadi Liakhovetski wrote:
> > > > On Fri, 26 Aug 2011, Simon Horman wrote:
> > > > 
> > > > > This patch is based on "ARM: arch-shmobile: Use multiple irq vectors for SDHI"
> > > > > 
> > > > > It removes multiplexing of the SDHI vectors and names each IRQ source
> > > > > to allow the SDHI driver to used source-specific handlers.
> > > > > 
> > > > > This is untested as I do not have access to a working g4evm.
> > > > > 
> > > > > Signed-off-by: Simon Horman <horms@verge.net.au>
> > > > > 
> > > > > ---
> > > > > 
> > > > > Requires "mmc: sdhi: Allow specific IRQ sources to use corresponding handlers."
> > > > > 
> > > > > *** compile tested only ***
> > > > > ---
> > > > >  arch/arm/mach-shmobile/board-g4evm.c |   26 ++++++++++++++++++++++-
> > > > >  arch/arm/mach-shmobile/intc-sh7377.c |   36 ++++++++++++++++-----------------
> > > > 
> > > > This second file should not be here, right?
> > > 
> > > I believe that the g4evm uses the sh7377 and that the multiplexing of
> > > SDHIinterrupts for the 7377 need to be removed in order to provide multiple
> > > SDHI irq sources.
> > > 
> > > Am I missing something?
> > 
> > Maybe not, I just misread your patch description as that it only should 
> > touch the board itself. Since intc-sh7377.c has to be touched too, this 
> > should be tested, I think. And I don't have any 7377 hardware available. 
> 
> I agree that this needs to be tested (or dropped).
> And its annoying that neither of us have the hardware at this time.

Hi Guennadi,

I spoke with Magnus yesterday and there doesn't seem to be any realistic
chance of accessing hardware to test this patch on in the near future.

So I would like to just leave it sitting in the mailing list archive as
an RFC for now.

      reply	other threads:[~2011-08-30  3:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26 10:13 [PATCH] [RFC] ARM: shmobile: g4evm: Use multiple irq vectors for SDHI Simon Horman
2011-08-26 12:17 ` Guennadi Liakhovetski
2011-08-26 12:34   ` Simon Horman
2011-08-26 12:56     ` Guennadi Liakhovetski
2011-08-26 13:06       ` Simon Horman
2011-08-30  3:45         ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110830034528.GA31103@verge.net.au \
    --to=horms@verge.net.au \
    --cc=g.liakhovetski@gmx.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox