From: Tony Lindgren <tony@atomide.com>
To: "T Krishnamoorthy, Balaji" <balajitk@ti.com>
Cc: "Buckley, Bryan" <bryan.buckley@ti.com>,
Kishore Kadiyala <kishorek.kadiyala@gmail.com>,
linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kishore Kadiyala <kishore.kadiyala@ti.com>,
Moiz Sonasath <m-sonasath@ti.com>,
Viswanath Puttagunta <vishp@ti.com>
Subject: Re: [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1
Date: Wed, 28 Sep 2011 11:06:52 -0700 [thread overview]
Message-ID: <20110928180652.GY6324@atomide.com> (raw)
In-Reply-To: <CANrkHUZo+P2TOMUH9udX-oQ5o64vEpOQVefrEUs1VkPxZxbBQA@mail.gmail.com>
* T Krishnamoorthy, Balaji <balajitk@ti.com> [110928 05:00]:
> Hi Tony,
>
> Can you queue this patch ?
Thanks, adding into fixes.
Tony
> On Fri, Sep 9, 2011 at 7:34 PM, T Krishnamoorthy, Balaji
> <balajitk@ti.com> wrote:
> > On Fri, Aug 12, 2011 at 8:43 PM, Buckley, Bryan <bryan.buckley@ti.com> wrote:
> >> On Fri, Jul 22, 2011 at 7:30 AM, Kishore Kadiyala
> >> <kishorek.kadiyala@gmail.com> wrote:
> >>>
> >>> On Fri, Jul 22, 2011 at 12:59 AM, Bryan Buckley <bryan.buckley@ti.com> wrote:
> >>> > Remove OMAP4_USBC1_ICUSB_PWRDNZ_MASK during enable/disable PWRDNZ mode for
> >>> > MMC1_PBIAS and associated extended-drain MMC1 I/O cell. This is in accordance
> >>> > with the control module programming guide. This fixes a bug where if trying to
> >>> > use gpio_98 or gpio_99 and MMC1 at the same time the GPIO signal will be
> >>> > affected by a changing SDMMC1_VDDS.
> >>> >
> >>> > Software must keep MMC1_PBIAS cell and MMC1_IO cell PWRDNZ signals low whenever
> >>> > SDMMC1_VDDS ramps up/down or changes for cell protection purposes.
> >>> >
> >>> > MMC1 is based on SDMMC1_VDDS whereas USBC1 is based on SIM_VDDS therefore
> >>> > they can operate independently.
> >>> >
> >>> > Signed-off-by: Bryan Buckley <bryan.buckley@ti.com>
> >>>
> >>> Good catch,
> >>>
> >>> Acked-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
> >>>
> >>
> >> Any other comments from anyone else? Noticed that this commit isn't
> >> in any upstream branches. This patch will fix issues with people who
> >> want to use GPIO 98/99 AND MMC1 at the same time. Would be good to
> >> have this fix upstream.
> >>
> > FWIW: Tested on OMAP4 Blaze
> > Tested-by: Balaji T K <balajitk@ti.com>
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-09-28 18:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 19:29 [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1 Bryan Buckley
2011-07-22 12:30 ` Kishore Kadiyala
2011-08-12 15:13 ` Buckley, Bryan
2011-09-09 14:04 ` T Krishnamoorthy, Balaji
2011-09-28 12:34 ` T Krishnamoorthy, Balaji
2011-09-28 18:06 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110928180652.GY6324@atomide.com \
--to=tony@atomide.com \
--cc=balajitk@ti.com \
--cc=bryan.buckley@ti.com \
--cc=kishore.kadiyala@ti.com \
--cc=kishorek.kadiyala@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-sonasath@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=vishp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).