From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] OMAP4: MMC: fix power and audio issue, decouple USBC1 from MMC1 Date: Wed, 28 Sep 2011 11:06:52 -0700 Message-ID: <20110928180652.GY6324@atomide.com> References: <1311276543-9374-1-git-send-email-bryan.buckley@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org To: "T Krishnamoorthy, Balaji" Cc: "Buckley, Bryan" , Kishore Kadiyala , linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, Santosh Shilimkar , Kishore Kadiyala , Moiz Sonasath , Viswanath Puttagunta List-Id: linux-mmc@vger.kernel.org * T Krishnamoorthy, Balaji [110928 05:00]: > Hi Tony, >=20 > Can you queue this patch ? Thanks, adding into fixes. Tony =20 > On Fri, Sep 9, 2011 at 7:34 PM, T Krishnamoorthy, Balaji > wrote: > > On Fri, Aug 12, 2011 at 8:43 PM, Buckley, Bryan wrote: > >> On Fri, Jul 22, 2011 at 7:30 AM, Kishore Kadiyala > >> wrote: > >>> > >>> On Fri, Jul 22, 2011 at 12:59 AM, Bryan Buckley wrote: > >>> > Remove OMAP4_USBC1_ICUSB_PWRDNZ_MASK during enable/disable PWRD= NZ mode for > >>> > MMC1_PBIAS and associated extended-drain MMC1 I/O cell. This is= in accordance > >>> > with the control module programming guide. This fixes a bug whe= re if trying to > >>> > use gpio_98 or gpio_99 and MMC1 at the same time the GPIO signa= l will be > >>> > affected by a changing SDMMC1_VDDS. > >>> > > >>> > Software must keep MMC1_PBIAS cell and MMC1_IO cell PWRDNZ sign= als low whenever > >>> > SDMMC1_VDDS ramps up/down or changes for cell protection purpos= es. > >>> > > >>> > MMC1 is based on SDMMC1_VDDS whereas USBC1 is based on SIM_VDDS= therefore > >>> > they can operate independently. > >>> > > >>> > Signed-off-by: Bryan Buckley > >>> > >>> Good catch, > >>> > >>> Acked-by: =C2=A0Kishore Kadiyala > >>> > >> > >> Any other comments from anyone else? =C2=A0Noticed that this commi= t isn't > >> in any upstream branches. This patch will fix issues with people w= ho > >> want to use GPIO 98/99 AND MMC1 at the same time. =C2=A0Would be g= ood to > >> have this fix upstream. > >> > > FWIW: Tested on OMAP4 Blaze > > Tested-by: Balaji T K > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html