From: Grant Likely <grant.likely@secretlab.ca>
To: Stephen Warren <swarren@nvidia.com>
Cc: Igor Grinberg <grinberg@compulab.co.il>,
Axel Lin <axel.lin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chris Ball <cjb@laptop.org>, Olof Johansson <olof@lixom.net>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-tegra: Add #ifdef CONFIG_OF guard for of_find_property
Date: Tue, 4 Oct 2011 12:32:32 -0600 [thread overview]
Message-ID: <20111004183232.GF2870@ponder.secretlab.ca> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173A2C6C97@HQMAIL01.nvidia.com>
On Mon, Oct 03, 2011 at 08:59:45AM -0700, Stephen Warren wrote:
> Igor Grinberg wrote at Monday, October 03, 2011 2:32 AM:
> > Hi Axel,
> >
> > On 10/03/11 06:07, Axel Lin wrote:
> > > I got below build error with "make tegra_defconfig;make"
> > > Add #ifdef CONFIG_OF guard for of_find_property to fix below build error:
> > >
> > > CC drivers/mmc/host/sdhci-tegra.o
> > > drivers/mmc/host/sdhci-tegra.c: In function 'sdhci_tegra_dt_parse_pdata':
> > > drivers/mmc/host/sdhci-tegra.c:157: error: implicit declaration of function 'of_find_property'
> ...
> > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> ...
> > > @@ -154,8 +154,11 @@ static struct tegra_sdhci_platform_data * __devinit sdhci_tegra_dt_parse_pdata(
> > > plat->cd_gpio = of_get_named_gpio(np, "cd-gpios", 0);
> > > plat->wp_gpio = of_get_named_gpio(np, "wp-gpios", 0);
> > > plat->power_gpio = of_get_named_gpio(np, "power-gpios", 0);
> > > +
> > > +#ifdef CONFIG_OF
> > > if (of_find_property(np, "support-8bit", NULL))
> > > plat->is_8bit = 1;
> > > +#endif
> >
> > Shouldn't we add a stub for the of_find_property() method to include/linux/of.h
> > instead of adding more ifdefs?
> > Or may be use of_get_property() method instead?
>
> I submitted a patch to add a stub of_find_property a little while back.
> Per https://lkml.org/lkml/2011/9/22/301, Grant applied it already. I'm
> not sure why it hasn't shown up in linux-next, since Grant's repo wasn't
> affected by the kernel.org downtime.
>
> Sorry for the breakage.
That's because I forgot to push out the tree. :-( Sorry. I've just
fixed it now.
g.
next prev parent reply other threads:[~2011-10-04 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 4:07 [PATCH] mmc: sdhci-tegra: Add #ifdef CONFIG_OF guard for of_find_property Axel Lin
2011-10-03 8:32 ` Igor Grinberg
2011-10-03 15:59 ` Stephen Warren
2011-10-04 18:32 ` Grant Likely [this message]
2011-10-03 16:39 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004183232.GF2870@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=axel.lin@gmail.com \
--cc=cjb@laptop.org \
--cc=grinberg@compulab.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox