From: Borislav Petkov <bp@alien8.de>
To: Barry Song <21cnbao@gmail.com>
Cc: Barry Song <Barry.Song@csr.com>,
pavel@ucw.cz, rjw@sisk.pl, linux-pm@lists.linux-foundation.org,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, workgroup.linux@csr.com,
Barry Song <baohua.song@csr.com>
Subject: Re: [PATCH] PM: HIBERNATION: add resume_delay kernel param as well as resume_delay
Date: Mon, 10 Oct 2011 09:00:28 +0200 [thread overview]
Message-ID: <20111010070028.GA11577@liondog.tnic> (raw)
In-Reply-To: <CAGsJ_4zSUYPrK3Bdo4p5bL25PO7orAJJByRAx2U=OT-JE62uHw@mail.gmail.com>
On Mon, Oct 10, 2011 at 02:34:45PM +0800, Barry Song wrote:
> >> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
> >> index b3da53c..f73a00e 100644
> >> --- a/kernel/power/hibernate.c
> >> +++ b/kernel/power/hibernate.c
> >> @@ -33,6 +33,7 @@
> >> static int nocompress = 0;
> >> static int noresume = 0;
> >> static int resume_wait = 0;
> >> +static int resume_delay = 0;
> >
> > These static variables get zeroed needlessly and checkpatch actually
> > warns about that. Maybe fix that up while you're there?
>
> yes. right. i initilized it to 0 to keep consistent coding style with
> the context because there were other variants doing that.
> i'd like to delete all initialization together as a seperate patch. Or
> do you want to do that?
Nah, you go ahead :-).
Thanks.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2011-10-10 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 5:44 [PATCH] PM: HIBERNATION: add resume_delay kernel param as well as resume_delay Barry Song
2011-10-10 6:26 ` Borislav Petkov
2011-10-10 6:34 ` Barry Song
2011-10-10 7:00 ` Borislav Petkov [this message]
2011-10-10 16:54 ` Pavel Machek
2011-10-10 21:46 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010070028.GA11577@liondog.tnic \
--to=bp@alien8.de \
--cc=21cnbao@gmail.com \
--cc=Barry.Song@csr.com \
--cc=baohua.song@csr.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox