From: Arnd Bergmann <arnd@arndb.de>
To: Shashidhar Hiremath <shashidharh@vayavyalabs.com>
Cc: Venkatraman S <svenkatr@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Ulf Hansson <ulf.hansson@stericsson.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Philip Rakity <prakity@marvell.com>,
Girish K S <girish.shivananjappa@linaro.org>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Aries Lee <arieslee@jmicron.com>,
Arindam Nath <arindam.nath@amd.com>,
Zhangfei Gao <zhangfei.gao@marvell.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Andrei Warkentin <awarkentin@vmware.com>,
Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, pk <pavitra@vayavyalabs.com>,
Sandeep <sandeep@vayavyalabs.com>,
Rayagond <rayagond@vayavyalabs.com>
Subject: Re: [PATCH 1/1] mmc:Extension of MMC Block IOCTL Command support for testing of non read/write Commands
Date: Thu, 17 Nov 2011 14:41:48 +0000 [thread overview]
Message-ID: <201111171441.48504.arnd@arndb.de> (raw)
In-Reply-To: <1321441734-24191-1-git-send-email-shashidharh@vayavyalabs.com>
On Wednesday 16 November 2011, Shashidhar Hiremath wrote:
> The patch provides An infrastructure to test commands other than Read/Write commands using the IOCTL interface.The Patch can be useful incase of validating the device to verify whether device support a given command or not. The result of the sent command will be written to the result element of the mmc_ioc_cmd structure passed through IOCTL interface.
>
> Signed-off-by: Shashidhar Hiremath <shashidharh@vayavyalabs.com>
Hi Shashidhar,
Unfortunately, I have to tell you that an implementation like this is
inappropriate for a number of reasons. My feeling is that most
importantly you should instead have the test logic entirely in user
space and only call the existing ioctl in the kernel. This would
make the entire patch obsolete, so I'm not commenting on the other
problems.
What has lead you to implementing the individual test cases in the
kernel?
Arnd
next prev parent reply other threads:[~2011-11-17 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 11:08 [PATCH 1/1] mmc:Extension of MMC Block IOCTL Command support for testing of non read/write Commands Shashidhar Hiremath
2011-11-17 10:34 ` S, Venkatraman
2011-11-17 11:18 ` Shashidhar Hiremath
2011-11-17 12:20 ` S, Venkatraman
2011-11-17 12:29 ` Shashidhar Hiremath
2011-11-17 14:41 ` Arnd Bergmann [this message]
2011-11-18 13:09 ` Shashidhar Hiremath
2011-11-22 16:04 ` Arnd Bergmann
2011-11-24 4:36 ` Shashidhar Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111171441.48504.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=arieslee@jmicron.com \
--cc=arindam.nath@amd.com \
--cc=awarkentin@vmware.com \
--cc=cjb@laptop.org \
--cc=girish.shivananjappa@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=pavitra@vayavyalabs.com \
--cc=prakity@marvell.com \
--cc=rayagond@vayavyalabs.com \
--cc=sandeep@vayavyalabs.com \
--cc=shashidharh@vayavyalabs.com \
--cc=svenkatr@ti.com \
--cc=ulf.hansson@stericsson.com \
--cc=zhangfei.gao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox