From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] mmc: ushc: fix an endianness conversion in ushc_request() Date: Mon, 21 Nov 2011 00:06:05 +0300 Message-ID: <20111120210605.GC7354@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from rcsinet15.oracle.com ([148.87.113.117]:24124 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753824Ab1KTVG2 (ORCPT ); Sun, 20 Nov 2011 16:06:28 -0500 Content-Disposition: inline Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Chris Ball Cc: Jesper Juhl , linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org The ->cmd_idx field is 8 bits, not 16 so the call to cpu_to_le16() will probably set cmd_idx to zero here on big endian systems. Signed-off-by: Dan Carpenter --- This is a static checker bug. Untested. diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c index f08f944..8b7367a 100644 --- a/drivers/mmc/host/ushc.c +++ b/drivers/mmc/host/ushc.c @@ -278,7 +278,7 @@ static void ushc_request(struct mmc_host *mmc, struct mmc_request *req) ushc->current_req = req; /* Start cmd with CBW. */ - ushc->cbw->cmd_idx = cpu_to_le16(req->cmd->opcode); + ushc->cbw->cmd_idx = req->cmd->opcode; if (req->data) ushc->cbw->block_size = cpu_to_le16(req->data->blksz); else